Modernize sniffio integration #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `sniffio.thread_local` to indicate which async library is running, instead of the deprecated `sniffio.current_async_library_cvar`. This allows us to remove a number of workarounds for the contextvar being inherited where it shouldn't be.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2700 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 113 113
Lines 16885 16917 +32
Branches 3036 3049 +13
=======================================
+ Hits 16707 16739 +32
Misses 123 123
Partials 55 55
|
|
Why was this merged with failing mypy run? |
|
Because mypy was already failing on master, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
sniffio.thread_localto indicate which async library is running, instead of the deprecatedsniffio.current_async_library_cvar. This allows us to remove a number of workarounds for the contextvar being inherited where it shouldn't be.