Fix of all signals. Script to annotate signals automatically.#162
Merged
Conversation
rr-
approved these changes
Aug 27, 2021
This was referenced Aug 27, 2021
Closed
Collaborator
|
I love the approach and I have been using CST as well for annotating QFlags better. I am worried though because your changes have marked incorrectly a method as a signal : QtWidgets.QGraphicsScene :
focusOnTouch is actually a property (see https://doc.qt.io/qt-5/qgraphicsscene.html) . If this one was marked incorrectly, there could be others. Could you investigate this particular case and see if it is a general problem or maybe just a PyQt5 stubs bug. While working with QFlags and CST, I have found a few buggy generated classes. Quick reviewing the changes did not reveal anything else. |
Collaborator
|
I checked again. Actually, focusOnTouch is already incorrectly declared as a signal, it has nothing to do with your script. So, I'll complete the review and organize the merging. |
bluebird75
approved these changes
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.