Add binary operators to flag classes#164
Closed
rr- wants to merge 2 commits into
Closed
Conversation
Collaborator
|
Hi Marcin. Very nice effort. I have been running more or less the same effort in #153 . My work is a bit more extensive because I tried to cover all operations on QFlag and enum test bases. I am also using libcst for this effort. I also discovered that not all QFlag based classes are equally implemented, some of them have special handling of the OR combination and some not. |
Author
|
@bluebird75 thank you. I didn't notice your PR so sorry for the duplicated effort. Let's go with your PR. I'd appreciate if you looked at my script and checked if there's anything you like to incorporate within your PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a script in similar vibe to #162
Fixes errors such as