Fix annotations for QAbstractItemModel signals#167
Closed
james-emerton wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Nice stuff. You are missing the following signals :
Could you add them to your PR ? If you could also add one file in the test directory that would be nice. |
bluebird75
requested changes
Nov 29, 2021
Collaborator
bluebird75
left a comment
bluebird75
left a comment
There was a problem hiding this comment.
ready to merge as soon as you add the missing signals.
Collaborator
|
Equivalent changes have been merged as part of PR #162 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the stubs for QAbstractItemModel to mark all the signals as the correct type.