Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate shape logic into a separate file #4708

Merged
merged 9 commits into from
Jun 1, 2021

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented May 18, 2021

Proposal.

@twiecki twiecki changed the base branch from v4 to reintro_shape May 18, 2021 14:04
@twiecki twiecki changed the title Reintro shape sep file Separate shape logic into a separate file May 18, 2021
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can squash-merge when tests pass

@twiecki twiecki merged commit 669a6e7 into reintro_shape Jun 1, 2021
@twiecki twiecki deleted the reintro_shape_sep_file branch June 1, 2021 21:03
michaelosthege added a commit that referenced this pull request Jun 4, 2021
michaelosthege added a commit that referenced this pull request Jun 4, 2021
twiecki added a commit that referenced this pull request Jun 4, 2021
twiecki added a commit that referenced this pull request Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants