Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate shape logic into a separate file #4708

Merged
merged 9 commits into from
Jun 1, 2021
Merged

Separate shape logic into a separate file #4708

merged 9 commits into from
Jun 1, 2021

Commits on May 18, 2021

  1. Separate shape stuff into a separate file.

    @twiecki
    twiecki committed May 18, 2021
    Configuration menu
    Copy the full SHA
    e3f6de6 View commit details
    Browse the repository at this point in the history

  2. Fix name of new function.

    @twiecki
    twiecki committed May 18, 2021
    Configuration menu
    Copy the full SHA
    72ae4d0 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Add missing import

    @michaelosthege
    michaelosthege authored May 23, 2021
    Configuration menu
    Copy the full SHA
    c514130 View commit details
    Browse the repository at this point in the history

  2. Fix import order

    @michaelosthege
    michaelosthege authored May 23, 2021
    Configuration menu
    Copy the full SHA
    19b9c88 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Add doc-strings for find_size and maybe_resize.

    @twiecki
    twiecki committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    a2f21d9 View commit details
    Browse the repository at this point in the history

  2. Move shape.py contents to shape_utils.py. Fix tests.

    @twiecki
    twiecki committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    26e6da0 View commit details
    Browse the repository at this point in the history

  3. Pass size kwarg to maybe_resize.

    @twiecki
    twiecki committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    985926a View commit details
    Browse the repository at this point in the history

  4. No keyword arguments to maybe_resize.

    @twiecki
    twiecki committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    8d33e70 View commit details
    Browse the repository at this point in the history

  5. Move convert_size and convert_shape back to dist().

    @twiecki
    twiecki committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    53d60f5 View commit details
    Browse the repository at this point in the history