-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement backwards-compatible shape and dims with Ellipsis support #4696
Conversation
4f92f9f
to
ce96c84
Compare
2f124df
to
51a0f0b
Compare
I think this looks great! |
Just changed base to |
51a0f0b
to
fbcce93
Compare
After rebasing I'm now pushing this branch commit by commit, so we get CI results on all of them. |
978017e
to
32822b7
Compare
Let me try and finish up the shape.py PR soon.
…On Sun, May 23, 2021, 14:39 Oriol Abril-Pla ***@***.***> wrote:
+1 on merging, further improvement and simplification can come in
follow-up PRs, I don't think there is discussion in terms of functionality
anymore so future PRs should not have any visible effect.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGEVCRWV3P5MVXT5RUDTPDZRNANCNFSM44342NCA>
.
|
08cbb33
to
ab5f44f
Compare
Co-authored-by: Thomas Wiecki <[email protected]>
Co-authored-by: Ricardo <[email protected]> Co-authored-by: Thomas Wiecki <[email protected]>
Co-authored-by: Thomas Wiecki <[email protected]> Co-authored-by: Ricardo <[email protected]>
669a6e7
to
fda8cbc
Compare
Co-authored-by: Michael Osthege <[email protected]>
fda8cbc
to
8bdc225
Compare
As we decided in todays lab meeting is rebased this branch so we can merge it. There were quite a few git conflicts, as anticipated, but it looks like nothing broke. |
OK good to merge from my end!
…On Fri, Jun 4, 2021, 19:01 Michael Osthege ***@***.***> wrote:
As we decided in todays lab meeting
<https://github.com/pymc-devs/pymc3/wiki/Project-Meeting-Minutes#friday-june-4-2021>
is rebased this branch so we can merge it.
There were quite a few git conflicts, as anticipated, but it looks like
nothing broke.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4696 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFETGHAFFJYKZERNMY25OTTREBHLANCNFSM44342NCA>
.
|
Co-authored-by: Oriol Abril-Pla <[email protected]>
Thanks to everyone who helped get this over the finish line, especially the herculean efforts of @michaelosthege! Also thanks for helpful review from @brandonwillard, @ricardoV94, @OriolAbril and everyone else. |
Here is what I did:
Create a diff between #4693 and #4667 and stage that diff onto a branch off of #4693 (no conflicts!). I then ran
git commit -p
and only selected those that seemed necessary here. Mostly there were some changes to tests that changedsize
toshape
I did not commit.Remember: Before merging still need to change author to @michaelosthege.