Bump types-toml from 0.10.3 to 0.10.4#5805
Conversation
|
Seems like we hit the timeout when we change a dependency. With pytest we could have some doubt but I don't think this new version of types-toml make the test that much slower. |
|
Pff.. This is becoming very difficult to debug. Why would updating a dependency lead to hanging on 2 specific tests on 3 specific versions/environments... I have no clue where to start debugging this.. |
|
This is a github actions issue imo. We can't know what machine is used physical or virtual that will be a little slower and there also might be an issue with having to rebuild the cache for new dependencies. We should probably make the timeout longer, and move on ? |
|
Let's try with 90 minutes. I wonder if it will pass this time though, it seemed to be completely stuck when I did a little investigation previously. |
|
Still fails... I don't think this is due to the recent timeout change. Timeouts were added in #5752 and changed in #5755. Seven days later we merged #5777, where all tests passed without issue in 4 minutes. So the failure is not consistent for all dependencies upgrades... I'm actually going to try and see if reverting #5777 helps here. |
|
Well... Now |
Pull Request Test Coverage Report for Build 1863301639
💛 - Coveralls |
|
@dependabot recreate |
Bumps [types-toml](https://github.com/python/typeshed) from 0.10.3 to 0.10.4. - [Release notes](https://github.com/python/typeshed/releases) - [Commits](https://github.com/python/typeshed/commits) --- updated-dependencies: - dependency-name: types-toml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/pip/types-toml-0.10.4
branch
from
c11aa76 to
0d3500e
Compare
|
Hmm... The test are clearly getting further than without the change. But one still times out. |
Are you sure ? It seems everything worked. |
|
@Pierre-Sassoulas Not sure if we want to merge this (same goes for the We did get a little further (50% into the tests) than without my recent "fix". Edit: Failed attempt: https://github.com/PyCQA/pylint/actions/runs/1863301639/attempts/1 |
Yeah, maybe we need to have a little more leeway with the timeout ? (The link you gave has all tests passing ?) |
I mean, that doesn't really solve the issue though. Tests normally are <5 minutes, so 30 minutes should be more than enough to account for slow runners and tests taking a bit longer than normal. An increase of factor 6 in test time is a try abnormality that should probably be solved.
Linux 3.8 doesn't pass. It also skips the coverage step because of it. |
👍 You're right, I did not see the difference was this large. Here's a screenshot on my side : |
|
Opened actions/runner#1696 for the bug in the attempts view. That's quite annoying. |
|
OK, I went to the job directly and it did timeout. Could it be because there was a single core on the runner and we still run jobs using two cores ? |
|
According to this https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners they should always have two cores... |
No I checked we have the commit to remove 2+ core tests. |
|
I just did a new run and it passed as well. I would be okay with merging this. |
3 participants
Bumps types-toml from 0.10.3 to 0.10.4.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)