-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Don't assume test runners have more than 2 cores available #5816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 1858098748
π - Coveralls |
|
Should we can consider reverting #5755 then? |
We could I think. It might make sense, although I'm not sure if there is a difference between organisations' and individual runners and if those could affect run time (I don't think so). |
AFAIK the main / only difference is the number of concurrent runners. |
|
I'd support revering then! |
|
@Pierre-Sassoulas No! This needs to be merged first as this is what's causing all the time outs. Subsequently we can rebase all the dependabot PRs and revert #5755. Haven't looked at the code yet, but I don't think that PR fixes this. I believe the way this test is invoked sets the number of jobs automatically to |
|
Btw, thinking about this: should we check if there are two cores available as well? I feel like that's a bare minimum for any test runner nowadays, but that could still crash/hang these tests.. |
Type of Changes
Description
This fixes the CI issues we were seeing in #5778 and #5805.
The second argument of these tuples is used to determine the number of jobs. However, the Linux runner only has two cores available. I'm not sure why this is different on Linux and Windows, but I think because we were trying to use more processes than available cores the test became either very slow or completely locked up.
You can see that we these changes both #5778 and #5805 pass the tests in expected times on all environments.