Add timeouts for CI jobs#5752
Merged
cdce8p merged 1 commit intopylint-dev:mainfrom Jan 31, 2022
Merged
Conversation
Collaborator
|
60 minutes is more than enough! I would even consider setting it to 45 or 50, that's more than twice they usually take. |
Member
Author
👍🏻 We can leave some headroom. It's still much better than the default 6h timeout. Usually those are issues with Github Actions anyway. |
Pull Request Test Coverage Report for Build 1774619958
💛 - Coveralls |
Pierre-Sassoulas
approved these changes
Jan 31, 2022
Member
|
Great catch @cdce8p ! Should we change to 45mn before merging ? |
Member
Author
Don't think that's necessary. The primer tests are somewhat separate from the rest already. 1h also isn't that long. Still an improvement over 6h though. |
This was referenced Jan 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I recently had a job run for 6h just to fail. Usually they all complete in <10min (CI) / <30min (Primer). So anything that is taking longer than that is probably going to fail anyway.
This PR adds
timeout-minutesto the individual jobs to abort them after a reasonable amount of time. Usually 2x what they actually need. https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes/CC: @DanielNoord Is 60min enough for Primer jobs? From what I've seen an individual one usually takes 20min.