Change http:// to https:// in several places (Fix for #6391) #8587

noi5e · 2020-10-15T20:23:56Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing! This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

🤓 A little background:

Basically we need to remove http:// and replace it with https:// in multiple files, so that the site can continue to load content as normal. See below and issue #6391 for more information.

Chrome will soon start blocking any http content loaded from an https page - not just scripts and iframes, but images, etc.
https://www.bleepingcomputer.com/news/google/google-chrome-to-gradually-start-blocking-mixed-content-by-default/

✒️ What to Change

There are a few places in the codebase where we can make this change. Please select ONE file to make a pull request (more info below), and leave the rest for other first-timers!

tools_places.html.erb:

plots2/app/views/notes/tools_places.html.erb

Line 9 in 76f000c

attribution: "<a href='http://openstreetmap.org'>OSM</a> tiles by <a href='http://mapbox.com'>MapBox</a>",
db/seeds.rb:

plots2/db/seeds.rb

Line 75 in 76f000c

"field_tms_url_value"=>"http://archive.publiclaboratory.org/leaflet/?\
~~notify_moderators_of_comment_spam.html.erb~~: claimed, awaiting merge in Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

What Do I Do If Everything's Been Taken?

You can search this repository for instances of "http" like so:

Completed - Please do not claim these! They have already been completed.

drupal_content_type_map.rb: merged in Update drupal_content_type_map.rb #8666
notify_moderators_of_spam.html.erb: merged in Update notify_moderators_of_spam.html.erb #8669
_history.html.erb: merged in Change http to https in _history.html.erb (#8632) #8653

📋 Step by Step

🙋 Claim this issue: Make a comment on this page, claiming one of the files above. If someone else has already claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update the file you've chosen by navigating to it. You can edit the line directly by clicking on the little pen icon.
💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

See this page for some help in taking your first steps!

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

welcome · 2020-10-15T20:24:00Z

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

yashmohan100 · 2020-10-15T21:05:56Z

Hi @noi5e , Can i work on this issue ?

yashmohan100 · 2020-10-15T21:09:52Z

I have taken the first option

drupal_content_type_map.rb:

plots2/app/models/drupal_content_type_map.rb

Lines 32 to 34 in 76f000c

    
           l = "<a href='http://creativecommons.org/publicdomain/zero/1.0/'>Public Domain</a>" if field_license_value == 'publicdomain' 
        
           l = "<a href='http://creativecommons.org/licenses/by/3.0/'>CC-BY</a>" if field_license_value == 'cc-by' 
        
           l = "<a href='http://creativecommons.org/licenses/by-sa/3.0/'>CC-BY-SA</a>" if field_license_value == 'cc-by-sa'

noi5e · 2020-10-15T21:11:10Z

@yashmohan100 Please go ahead!

Kennygrace · 2020-10-16T00:12:48Z

Hello @noi5e, Please I would like to take up the second option on this issue

sagarpreet-chadha · 2020-10-16T02:30:29Z

Sure @Kennygrace 😄

amanda-ariyaratne · 2020-10-16T04:47:01Z

@noi5e I would like to work on the third option

MinervaLong · 2020-10-16T11:51:49Z

Hello, @noi5e I would like to work on the fourth option, thank you.

DhrutikPatel · 2020-10-16T17:03:18Z

Hello, @noi5e I would like to do PR on fifth option

mpmadhavig · 2020-10-16T17:39:08Z

Hi, I would like to work on the sixth option

cesswairimu · 2020-10-17T20:05:55Z

Maybe we should separate each file changes to individual issues for review and merging purposes(we have automatic closure of issue once a linked PR is merged) @noi5e would you like to separate these? please ping me if you need any help. Thanks a lot for opening this 💯

noi5e · 2020-10-17T20:20:02Z

@cesswairimu Okay, got it. I think I'll have some time later today or tomorrow to make separate issues.

cesswairimu · 2020-10-17T20:21:49Z

Thanks @noi5e

ebarry · 2020-10-19T13:38:33Z

Thank you @noi5e ! Excellent signposting for the community.

tejaswini22199 · 2020-10-19T17:48:08Z

Hey @noi5e is there any box that is not merged yet? or all the 6 files have been modified?

cesswairimu · 2020-10-19T18:40:50Z

Reopening

mscreation28 · 2020-10-19T20:34:36Z

Hey @noi5e I am trying to to do my first pull request. Can you assign me this task if any left and tell me what to change in reopened issue?

noi5e · 2020-10-20T06:25:10Z

@cesswairimu Okay, I opened new FTO issues for 5 out of the 6 instances (in the 6th instance, the PR was already merged). Hope that helps the organization a little bit.

Any first-time contributor that's reading this (@mscreation28, others) and still looking for an FTO issue: I believe that there are still instances of http left in the codebase that need to be converted to https. Please read the initial notes I posted for this issue and look at the animated GIF on how to search the codebase for http.

From there you can write your own FTO issue for the file... Or maybe someone who just made an FTO contribution and wants to make an issue can do it (after writing 6 FTO issues, I'm kinda looking forward to contributing to Public Lab in another way 😋)

jwalit21 · 2020-10-20T07:27:24Z

hey @noi5e..

Till i've found these 2 new issues in files where we might have to change http to https based on how you have explained in GIF.
Those files are 1. notes_controller_test.rb 2. critical_path_css.yml

I'm a first-timer, and i want to contribute in this project.
so can you please confirm that the issues i founded i correct and valid or not?

And if it is valid then can you please assign this issue to me by creating new FTO issue?

Thank you @noi5e

noi5e · 2020-10-20T18:34:19Z

@jwalit21 Awesome, that's great! I'll leave it to @jywarren and @cesswairimu to decide if they want the changes to be made in those files...

Also, I encourage you to make your own FTO issue. (I'm pretty new to this codebase and only just recently completed my own FTO issue). More info here: https://publiclab.org/notes/warren/10-31-2016/create-a-welcoming-first-timers-only-issue-to-invite-new-software-contributors

cesswairimu · 2020-10-21T12:35:22Z

Great 🎉 , thanks @noi5e 🎉 @jwalit21 I will check if the hyperlinks can be changed on the tests and revert. Thanks

jayaram2000 · 2020-10-23T16:55:43Z

Hey, I'm new to open source and would love to contribute. Are there any open issue?

mingweisoo · 2020-10-25T09:44:59Z

hi I'd like to make changes to db/seeds.rb:

mingweisoo · 2020-10-25T15:34:46Z

Hi which ones still need to replaced?

cesswairimu · 2020-10-26T07:06:57Z

Hi @evansusu, these all have been assigned to people. Thanks

noi5e · 2020-10-31T06:32:03Z

@evansusu @jayaram2000 Even though these six instances have already been claimed by other people, there are still other places which have http instead of https.

You can search for http in plots2 like so:

If you find a place that needs the change, leave a comment here and let us know! You can make a first-timers-only issue, and assign yourself to it (and we can help you with that) :)

YubaNeupane · 2020-11-01T02:30:40Z

Can I fix this issue?

jayaram2000 · 2020-11-01T12:25:16Z

@noi5e Can I take up openid_test.rb file?

cesswairimu · 2020-11-23T17:35:41Z

@jwalit21 sorry this skipped my mind. Replacing the test looks like it would be okay. Do let me know if you would like to work on that and I will create an FTO for you. Thanks

…8587) (#8593) * Update notify_moderators_of_comment_spam.html.erb Changed http to https * Hostname update in notify_moderators_of_comment_spam.html.erb Hostname is loaded from configuration file instead of hardcoded hostname

symrin · 2020-12-20T14:23:29Z

@noi5e Can I take the user_tags.yml file, and make the change there?

cesswairimu · 2020-12-21T11:13:51Z

Hi @symrin, you can take it up as a trial issue...not sure it will affect the tests. If you are up to do the changes and do the PR and see if the tests will be all good please go ahead. Thanks

cesswairimu · 2020-12-31T08:17:14Z

All the issues broken out from here have all been solved and merged 🎉 🎉... Thanks a lot everyone and many thanks to @noi5e for opening this and helping all the new contributors 🙌 🙌

I have opened some more ftos for the remaining instances on app/views... and linking back to the main issue here for further discussions . Thanks again all ❤️

…ubliclab#8587) (publiclab#8593) * Update notify_moderators_of_comment_spam.html.erb Changed http to https * Hostname update in notify_moderators_of_comment_spam.html.erb Hostname is loaded from configuration file instead of hardcoded hostname

noi5e added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 15, 2020

amanda-ariyaratne mentioned this issue Oct 16, 2020

Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

Merged

5 tasks

DhrutikPatel mentioned this issue Oct 16, 2020

Changed http:// to https:// on line #9 #8596

Merged

mpmadhavig mentioned this issue Oct 16, 2020

Updated seed.rb - line 75, http to https #8597

Closed

5 tasks

yashmohan100 mentioned this issue Oct 17, 2020

Change to https:// at app/models/drupal_content_type_map.rb #8588

Closed

5 tasks

cesswairimu closed this as completed in #8596 Oct 19, 2020

cesswairimu reopened this Oct 19, 2020

Onyinye91-ctrl mentioned this issue Oct 21, 2020

Change from http:// to https:// #8656

Closed

5 tasks

cesswairimu closed this as completed Dec 31, 2020

willow19 mentioned this issue Apr 22, 2021

Weed out issues in the Candidate List that have already been worked on. #9529

Open

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change http:// to https:// in several places (Fix for #6391) #8587

Change http:// to https:// in several places (Fix for #6391) #8587

noi5e commented Oct 15, 2020 •

edited

Loading

welcome bot commented Oct 15, 2020

yashmohan100 commented Oct 15, 2020

yashmohan100 commented Oct 15, 2020 •

edited

Loading

noi5e commented Oct 15, 2020

Kennygrace commented Oct 16, 2020

sagarpreet-chadha commented Oct 16, 2020

amanda-ariyaratne commented Oct 16, 2020

MinervaLong commented Oct 16, 2020

DhrutikPatel commented Oct 16, 2020

mpmadhavig commented Oct 16, 2020

cesswairimu commented Oct 17, 2020

noi5e commented Oct 17, 2020

cesswairimu commented Oct 17, 2020

ebarry commented Oct 19, 2020

tejaswini22199 commented Oct 19, 2020

cesswairimu commented Oct 19, 2020

mscreation28 commented Oct 19, 2020

noi5e commented Oct 20, 2020 •

edited

Loading

jwalit21 commented Oct 20, 2020

noi5e commented Oct 20, 2020

cesswairimu commented Oct 21, 2020

jayaram2000 commented Oct 23, 2020

mingweisoo commented Oct 25, 2020

mingweisoo commented Oct 25, 2020

cesswairimu commented Oct 26, 2020

noi5e commented Oct 31, 2020 •

edited

Loading

YubaNeupane commented Nov 1, 2020

jayaram2000 commented Nov 1, 2020

cesswairimu commented Nov 23, 2020 •

edited

Loading

symrin commented Dec 20, 2020

cesswairimu commented Dec 21, 2020 •

edited

Loading

cesswairimu commented Dec 31, 2020 •

edited

Loading

Change http:// to https:// in several places (Fix for #6391) #8587

Change http:// to https:// in several places (Fix for #6391) #8587

Comments

noi5e commented Oct 15, 2020 • edited Loading

🤔 What you will need to know.

🤓 A little background:

✒️ What to Change

What Do I Do If Everything's Been Taken?

Completed - Please do not claim these! They have already been completed.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

welcome bot commented Oct 15, 2020

yashmohan100 commented Oct 15, 2020

yashmohan100 commented Oct 15, 2020 • edited Loading

noi5e commented Oct 15, 2020

Kennygrace commented Oct 16, 2020

sagarpreet-chadha commented Oct 16, 2020

amanda-ariyaratne commented Oct 16, 2020

MinervaLong commented Oct 16, 2020

DhrutikPatel commented Oct 16, 2020

mpmadhavig commented Oct 16, 2020

cesswairimu commented Oct 17, 2020

noi5e commented Oct 17, 2020

cesswairimu commented Oct 17, 2020

ebarry commented Oct 19, 2020

tejaswini22199 commented Oct 19, 2020

cesswairimu commented Oct 19, 2020

mscreation28 commented Oct 19, 2020

noi5e commented Oct 20, 2020 • edited Loading

jwalit21 commented Oct 20, 2020

noi5e commented Oct 20, 2020

cesswairimu commented Oct 21, 2020

jayaram2000 commented Oct 23, 2020

mingweisoo commented Oct 25, 2020

mingweisoo commented Oct 25, 2020

cesswairimu commented Oct 26, 2020

noi5e commented Oct 31, 2020 • edited Loading

YubaNeupane commented Nov 1, 2020

jayaram2000 commented Nov 1, 2020

cesswairimu commented Nov 23, 2020 • edited Loading

symrin commented Dec 20, 2020

cesswairimu commented Dec 21, 2020 • edited Loading

cesswairimu commented Dec 31, 2020 • edited Loading

noi5e commented Oct 15, 2020 •

edited

Loading

yashmohan100 commented Oct 15, 2020 •

edited

Loading

noi5e commented Oct 20, 2020 •

edited

Loading

noi5e commented Oct 31, 2020 •

edited

Loading

cesswairimu commented Nov 23, 2020 •

edited

Loading

cesswairimu commented Dec 21, 2020 •

edited

Loading

cesswairimu commented Dec 31, 2020 •

edited

Loading