Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change http to https in notify_moderators_of_spam.html.erb #8630

Closed
noi5e opened this issue Oct 20, 2020 · 7 comments · Fixed by #8669 · May be fixed by Kennygrace/plots2#1
Closed

Change http to https in notify_moderators_of_spam.html.erb #8630

noi5e opened this issue Oct 20, 2020 · 7 comments · Fixed by #8669 · May be fixed by Kennygrace/plots2#1
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@noi5e
Copy link
Contributor

noi5e commented Oct 20, 2020

🔊 NOTE: (This issue is a part of Issue #8587 and has been claimed at the time of writing this issue. However, there are several places in the codebase where this change needs to happen, and issues haven't been made for each instance yet. If you are a first-time contributor, please refer to #8587 for more info on how to find instances of 'http' in the codebase. From there, you can make your own FTO issue and pull request to solve it.)

Please see #8587 for more context behind this issue.

@noi5e noi5e added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Oct 20, 2020
@noi5e
Copy link
Contributor Author

noi5e commented Oct 20, 2020

@cesswairimu @jywarren , @Kennygrace needs to be assigned to this issue, they have an open PR at Kennygrace#1.

I decided not to type up extensive issue notes if the contributor already has an open PR, I thought it would be overkill since it seems as if they don't need the help.

@cesswairimu
Copy link
Collaborator

Sounds good, thanks @noi5e

@Kennygrace
Copy link
Contributor

@noi5e This is what I worked on, and I made a PR already, should I do it again?

@noi5e
Copy link
Contributor Author

noi5e commented Oct 20, 2020

@Kennygrace no definitely don't do it again! I've linked to your PR here, so hopefully @jywarren or someone else will review it and merge it soon.

@cesswairimu
Copy link
Collaborator

@Kennygrace, it seems you made the pull request on your repo, you can create one on plots2. Thanks

@cesswairimu
Copy link
Collaborator

You can use this link main...Kennygrace:Kennygrace-patch-1

@Kennygrace
Copy link
Contributor

I've done it @cesswairimu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
3 participants