Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

amanda-ariyaratne · 2020-10-16T07:54:19Z

Changed http to https.

Fixes #8631 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome · 2020-10-16T07:54:21Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

gitpod-io · 2020-10-16T07:54:23Z

codecov · 2020-10-16T07:58:28Z

Codecov Report

❗ No coverage uploaded for pull request base (main@dddc3e7). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8593   +/-   ##
=======================================
  Coverage        ?   81.90%           
=======================================
  Files           ?      100           
  Lines           ?     5941           
  Branches        ?        0           
=======================================
  Hits            ?     4866           
  Misses          ?     1075           
  Partials        ?        0

amanda-ariyaratne · 2020-10-16T08:11:26Z

@noi5e I would like if someone can review my pull request. Thank you.

jywarren · 2020-10-16T14:49:11Z

app/views/admin_mailer/notify_moderators_of_comment_spam.html.erb

@@ -17,7 +17,7 @@
 <hr>
 <div class="footer">

-  <p>Visit the spam page here: <a href="http://publiclab.org/spam">http://publiclab.org/spam</a></p>
+  <p>Visit the spam page here: <a href="https://publiclab.org/spam">https://publiclab.org/spam</a></p>


Great catch! Thanks!

Actually i'll suggest something even more - see how we can fetch the hostname and insert it, in case this codebase is ever run on a different domain name?

From line 22:

Suggested change

<p>Visit the spam page here: <a href="https://publiclab.org/spam">https://publiclab.org/spam</a></p>

<p>Visit the spam page here: <a href="https://<%= ActionMailer::Base.default_url_options[:host] %>/spam">https://<%= ActionMailer::Base.default_url_options[:host] %>/spam</a></p>

It's a little harder to read, but what do you think?

Yes, it is a bit harder to read. But if it is okay, I can change it.

RuthNjeri

Looks good to me @amanda-ariyaratne

amanda-ariyaratne · 2020-10-20T17:19:00Z

@RuthNjeri Sorry I'm new to this. Is there anything for me to do next?

RuthNjeri · 2020-10-20T17:47:58Z

Hi, @amanda-ariyaratne not really, all you have to do is wait for the maintainers to approve and merge...

amanda-ariyaratne · 2020-10-21T06:38:14Z

great, thanks!

cesswairimu · 2020-10-26T07:48:12Z

restarting travis

gitpod-io · 2020-10-26T07:48:20Z

cesswairimu · 2020-11-23T17:42:52Z

restarting travis

gitpod-io · 2020-11-23T17:43:01Z

cesswairimu · 2020-11-23T18:09:11Z

I will try and rebase this branch

cesswairimu · 2020-11-23T18:20:08Z

That worked 🎉

cesswairimu

Thanks for working on this 🎉 and sorry this took a while

cesswairimu · 2020-11-23T18:22:17Z

@jywarren kindly do another review on this we have a pending "changes requested". Thanks

gitpod-io · 2020-12-17T06:11:05Z

Changed http to https

Hostname is loaded from configuration file instead of hardcoded hostname

codeclimate · 2020-12-17T08:33:35Z

Code Climate has analyzed commit f4f5ad7 and detected 0 issues on this pull request.

View more on Code Climate.

Changes requested were fixed. Thanks Jeff

welcome · 2020-12-17T09:17:32Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

cesswairimu · 2020-12-17T09:17:36Z

Thanks all 🎉

…ubliclab#8587) (publiclab#8593) * Update notify_moderators_of_comment_spam.html.erb Changed http to https * Hostname update in notify_moderators_of_comment_spam.html.erb Hostname is loaded from configuration file instead of hardcoded hostname

jywarren previously requested changes Oct 16, 2020

View reviewed changes

amanda-ariyaratne requested a review from jywarren October 18, 2020 04:17

noi5e mentioned this pull request Oct 20, 2020

Change http to https in notify_moderators_of_comment_spam.html.erb #8631

Closed

RuthNjeri reviewed Oct 20, 2020

View reviewed changes

cesswairimu closed this Oct 26, 2020

cesswairimu reopened this Oct 26, 2020

cesswairimu closed this Nov 23, 2020

cesswairimu reopened this Nov 23, 2020

cesswairimu force-pushed the http-to-https-8587-3 branch from d1056a8 to 7144c80 Compare November 23, 2020 18:09

cesswairimu approved these changes Nov 23, 2020

View reviewed changes

noi5e mentioned this pull request Dec 13, 2020

Change http:// to https:// in several places (Fix for #6391) #8587

Closed

11 tasks

cesswairimu closed this Dec 17, 2020

cesswairimu reopened this Dec 17, 2020

amanda-ariyaratne added 2 commits December 17, 2020 11:32

Update notify_moderators_of_comment_spam.html.erb

c9fb049

Changed http to https

Hostname update in notify_moderators_of_comment_spam.html.erb

f4f5ad7

Hostname is loaded from configuration file instead of hardcoded hostname

cesswairimu force-pushed the http-to-https-8587-3 branch from 7144c80 to f4f5ad7 Compare December 17, 2020 08:32

cesswairimu merged commit 8bb0cf7 into publiclab:main Dec 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

amanda-ariyaratne commented Oct 16, 2020 •

edited by cesswairimu

Loading

welcome bot commented Oct 16, 2020

gitpod-io bot commented Oct 16, 2020 •

edited

Loading

codecov bot commented Oct 16, 2020 •

edited

Loading

amanda-ariyaratne commented Oct 16, 2020

jywarren Oct 16, 2020

amanda-ariyaratne Oct 16, 2020 •

edited

Loading

RuthNjeri left a comment

amanda-ariyaratne commented Oct 20, 2020

RuthNjeri commented Oct 20, 2020

amanda-ariyaratne commented Oct 21, 2020

cesswairimu commented Oct 26, 2020

gitpod-io bot commented Oct 26, 2020

cesswairimu commented Nov 23, 2020

gitpod-io bot commented Nov 23, 2020

cesswairimu commented Nov 23, 2020

cesswairimu commented Nov 23, 2020

cesswairimu left a comment

cesswairimu commented Nov 23, 2020 •

edited

Loading

gitpod-io bot commented Dec 17, 2020

codeclimate bot commented Dec 17, 2020

welcome bot commented Dec 17, 2020

cesswairimu commented Dec 17, 2020

	<p>Visit the spam page here: <a href="https://publiclab.org/spam">https://publiclab.org/spam</a></p>
	<p>Visit the spam page here: <a href="https://<%= ActionMailer::Base.default_url_options[:host] %>/spam">https://<%= ActionMailer::Base.default_url_options[:host] %>/spam</a></p>

Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

Changed http to https in notify_moderators_of_comment_spam.html.erb (#8587) #8593

Conversation

amanda-ariyaratne commented Oct 16, 2020 • edited by cesswairimu Loading

welcome bot commented Oct 16, 2020

gitpod-io bot commented Oct 16, 2020 • edited Loading

codecov bot commented Oct 16, 2020 • edited Loading

Codecov Report

amanda-ariyaratne commented Oct 16, 2020

jywarren Oct 16, 2020

Choose a reason for hiding this comment

amanda-ariyaratne Oct 16, 2020 • edited Loading

Choose a reason for hiding this comment

RuthNjeri left a comment

Choose a reason for hiding this comment

amanda-ariyaratne commented Oct 20, 2020

RuthNjeri commented Oct 20, 2020

amanda-ariyaratne commented Oct 21, 2020

cesswairimu commented Oct 26, 2020

gitpod-io bot commented Oct 26, 2020

cesswairimu commented Nov 23, 2020

gitpod-io bot commented Nov 23, 2020

cesswairimu commented Nov 23, 2020

cesswairimu commented Nov 23, 2020

cesswairimu left a comment

Choose a reason for hiding this comment

cesswairimu commented Nov 23, 2020 • edited Loading

gitpod-io bot commented Dec 17, 2020

codeclimate bot commented Dec 17, 2020

welcome bot commented Dec 17, 2020

cesswairimu commented Dec 17, 2020

amanda-ariyaratne commented Oct 16, 2020 •

edited by cesswairimu

Loading

gitpod-io bot commented Oct 16, 2020 •

edited

Loading

codecov bot commented Oct 16, 2020 •

edited

Loading

amanda-ariyaratne Oct 16, 2020 •

edited

Loading

cesswairimu commented Nov 23, 2020 •

edited

Loading