Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ''unable to load version number'' problem #1789

Merged
merged 3 commits into from
Jan 25, 2021
Merged

fixed ''unable to load version number'' problem #1789

merged 3 commits into from
Jan 25, 2021

Conversation

vivek-30
Copy link

Fixes #1724.

@vivek-30 vivek-30 requested a review from a team as a code owner January 17, 2021 16:31
@gitpod-io
Copy link

gitpod-io bot commented Jan 17, 2021

@vivek-30
Copy link
Author

@harshkhandeparkar and @jywarren can you please review this?

@harshkhandeparkar
Copy link
Member

I saw the code but I am not sure how to check it 😂

@harshkhandeparkar
Copy link
Member

From what I can tell, it looks fine :)

@vivek-30
Copy link
Author

i have used chrome dev-tools for this . just by navigating to networks tab and then changed online mode to offline so that page renders slowly and then we can easily inspect it.

This is the working gif -
loading-version

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jywarren
Copy link
Member

This is awesome, thank you!!!!!

@jywarren jywarren merged commit ffdba0b into publiclab:main Jan 25, 2021
@welcome
Copy link

welcome bot commented Jan 25, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will be published to https://beta.sequencer.publiclab.org in a day or two. Please test out your work on this testing server and report back with a comment that all has gone well!
In the meantime, can you tell us your Twitter handle so we can thank you properly also do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Please find the link pinned in the issue section
Now that you've completed this, you can help someone else take their first step! Try looking at this list of first-timers-only issues, and see if someone else is waiting for feedback, or even stuck! 😕
People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉
See: Public Lab's coding community!

@jywarren
Copy link
Member

Hooray, thank you!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Loading version number" instead of "unable" message in UI
3 participants