Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Loading version number" instead of "unable" message in UI #1724

Closed
jywarren opened this issue Oct 15, 2020 · 7 comments · Fixed by #1789
Closed

Add "Loading version number" instead of "unable" message in UI #1724

jywarren opened this issue Oct 15, 2020 · 7 comments · Fixed by #1789

Comments

@jywarren
Copy link
Member

The message shown while loading the version number could use a tweak.

Screen Shot 2020-07-10 at 3 00 15 PM

It says "unable to load version number" until the page is finished loading. Maybe it should say:

Loading version number until it's loaded, but if it fails we rescue and try changing to Unable to load version number?

What do you think?

Originally posted by @jywarren in #1567 (comment)

@frappelatte28
Copy link

Hey! @jywarren Can I work on this issue?

@jywarren
Copy link
Member Author

That would be great! Would you like some help finding the area of code for this? I'd start by searching the codebase for ""unable to load version number" -- thanks!!

@vivek-30
Copy link

hi @frappelatte28 mam are you still solving this issue if not then i have made a decent progress regarding the same and want a feedback for that so is it ok if i will raise a PR for this issue

@frappelatte28
Copy link

Go ahead @vivek-30 I am busy with my semester exams, I will find some issues as soon as this semester thing ends.

@vivek-30
Copy link

Thank you mam ☺️

@vivek-30
Copy link

Hlo @jywarren sir, looking up the above issue i found something related which when modified gives desired output( but partially )
here what i have found in examples/index.html

Screenshot 2021-01-15 at 3 29 52 PM

One Thing which is a bit confusing is that when i test the project on port other than 3000 ( say- 4000 ) then it gives output as required but not on 3000 could you plz help me.

@vivek-30
Copy link

Actually ,sir its my bad 😅 ,It was just the offline cache that the browser was using that time .
But now it is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants