Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing continues even after no video feed #1411

Closed
ataata107 opened this issue Jan 2, 2020 · 5 comments · Fixed by #1797
Closed

Processing continues even after no video feed #1411

ataata107 opened this issue Jan 2, 2020 · 5 comments · Fixed by #1797

Comments

@ataata107
Copy link

ataata107 commented Jan 2, 2020

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?
ezgif com-video-to-gif (1)

Clicking the take photo button even if camera is disabled continues to do processing on a white canvas.

What did you expect to see that you didn't?

Expected the process to end because of no video stream

@vivek-30
Copy link

@ataata107 sir, is this issue still open?
if yes then i would love to work on this ☺️ .

@vivek-30
Copy link

@harshkhandeparkar i have solved this issue but still waiting for it to be assigned what should i do?

@harshkhandeparkar
Copy link
Member

Go ahead!

@vivek-30
Copy link

test

this is the working gif of above problem, is this ok?

@vivek-30
Copy link

Also i have submitted a PR #1789 around 5 days ago . Could you please review it as well. I am waiting for the feedback.Also Thanks for your time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants