Use consistent hash across NDEBUG/!NDEBUG builds.#3327
Use consistent hash across NDEBUG/!NDEBUG builds.#3327xfxyjwf merged 1 commit intoprotocolbuffers:masterfrom
Conversation
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Can one of the admins verify this patch? |
|
Can you send this as a CL instead? Better to have the original author of this code double check. |
|
@xfxyjwf Ack, I've filed a CL. I'll close this for now but keep the issue open until we've integrated the CL and pushed upstream. |
|
The CL has merged internally, as discussed offline, can we get this PR to merge as well? I think it would be useful to Envoy to remove the workaround we have in place as early as possible. Thanks. |
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Can one of the admins verify this patch? |
|
Thanks for helping resolve this! |
* Use protobuf from HEAD to ensure we have the protocolbuffers/protobuf#3327 fix for CI and local builds. Users can opt to use a specific release tag with the ENVOY_PROTOBUF_COMMIT env var. * Remove the workaround for protocolbuffers/protobuf#3327 in do_ci.sh. * Remove the multiple protobuf versions that existed because protocolbuffers/protobuf#2508 wasn't merged. * Add some evil symlink stuff to get @protobuf_bzl inferred from wherever WORKSPACE points the envoy_dependencies path at. As a bonus, enabled more verbose build of external deps so we don't sit around for minutes on initial checkout with no activity indicator. This can be done safely now as everyone should be at Bazel 0.5.2.
Use protobuf from HEAD to ensure we have the protocolbuffers/protobuf#3327 fix for CI and local builds. Users can opt to use a specific release tag with the ENVOY_PROTOBUF_COMMIT env var.
Use protobuf from HEAD to ensure we have the protocolbuffers/protobuf#3327 fix for CI and local builds. Users can opt to use a specific release tag with the ENVOY_PROTOBUF_COMMIT env var.
* Remove the workaround for protocolbuffers/protobuf#3327 in do_ci.sh. * Remove the multiple protobuf versions that existed because protocolbuffers/protobuf#2508 wasn't merged. * Add some evil symlink stuff to get @protobuf_bzl inferred from wherever WORKSPACE points the envoy_dependencies path at. As a bonus, enabled more verbose build of external deps so we don't sit around for minutes on initial checkout with no activity indicator. This can be done safely now as everyone should be at Bazel 0.5.2.
* build: undo some protobuf hacks, put some new ones in. * Remove the workaround for protocolbuffers/protobuf#3327 in do_ci.sh. * Remove the multiple protobuf versions that existed because protocolbuffers/protobuf#2508 wasn't merged. * Add some evil symlink stuff to get @protobuf_bzl inferred from wherever WORKSPACE points the envoy_dependencies path at. As a bonus, enabled more verbose build of external deps so we don't sit around for minutes on initial checkout with no activity indicator. This can be done safely now as everyone should be at Bazel 0.5.2. * Don't put verbose Bazel spew into query targets for coverage. * Always start from a clean test/coverage/BUILD, don't include it in the query.
5 participants
Fixes #3322.