ci: build thirdparty for both opt/dbg.#1223
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Jul 7, 2017
Merged
Conversation
Needed as a workaround for protocolbuffers/protobuf#3322. I'm going to work on an upstream fix once I unblock current dependencies on the merge of envoyproxy#1202. This increases image size from 2.3GB to 2.9GB. While it might be possible to only rebuild protobuf/lightstep, it's significantly more complicated throwaway build hacking to get there.
dnoe
reviewed
Jul 7, 2017
|
|
||
| export THIRDPARTY_DEPS=/tmp | ||
| export THIRDPARTY_SRC=/thirdparty | ||
| export THIRDPARTY_BUILD=/thirdparty_build |
Contributor
There was a problem hiding this comment.
This directory can be deleted now, right? I think this should get added into the script, or at least into the PR description that bazel clean is required.
Member
Author
|
This doesn't affect non-CI builds. The directory is never created in the
Docker image.
…On Fri, Jul 7, 2017 at 8:54 AM Dan Noé ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ci/build_container/build_container.sh
<#1223 (comment)>:
> @@ -37,8 +37,18 @@ fi
export THIRDPARTY_DEPS=/tmp
export THIRDPARTY_SRC=/thirdparty
-export THIRDPARTY_BUILD=/thirdparty_build
This directory can be deleted now, right? I think this should get added
into the script, or at least into the PR description that bazel clean is
required.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1223 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKaLv8hD1Z6rUG8kV4KL-SNd-U_6ICdhks5sLiqOgaJpZM4OQ4ZW>
.
|
Member
Author
|
Long term fix in flight at protocolbuffers/protobuf#3327 |
mattklein123
approved these changes
Jul 7, 2017
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Jul 7, 2017
htuch
added a commit
that referenced
this pull request
Jul 7, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Use bazel --batch **What this PR does / why we need it**: Give a try to address `Server crashed during startup.` in prow, CI doesn't need bazel server at all. **Release note**: ```release-note None ```
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. use bazel --batch for release script **What this PR does / why we need it**: Follow up on envoyproxy#1223, bazel server consumes more memory while it doesn't provide benefits in CI. This will make postsubmit more stable. **Release note**: ```release-note None ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This PR implements all of the engine-related classes, like `Engine` and `EngineBuilder`. Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/or C++ Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This PR implements all of the engine-related classes, like `Engine` and `EngineBuilder`. Risk Level: Low Testing: N/A, will follow up when everything is finished with e2e testing + unit testing in Python and/or C++ Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed as a workaround for protocolbuffers/protobuf#3322. I'm going to work on an
upstream fix once I unblock current dependencies on the merge of
#1202.
This increases image size from 2.3GB to 2.9GB. While it might be possible to only rebuild
protobuf/lightstep, it's significantly more complicated throwaway build hacking to get there.