Skip to content

build: switch protobuf version to pinned HEAD commit.#1304

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:protobuf-recipe
Jul 21, 2017
Merged

build: switch protobuf version to pinned HEAD commit.#1304
htuch merged 1 commit intoenvoyproxy:masterfrom
htuch:protobuf-recipe

Conversation

@htuch
Copy link
Member

@htuch htuch commented Jul 21, 2017

Use protobuf from HEAD to ensure we have the
protocolbuffers/protobuf#3327 fix for CI and local
builds. Users can opt to use a specific release tag with the
ENVOY_PROTOBUF_COMMIT env var.

Use protobuf from HEAD to ensure we have the
protocolbuffers/protobuf#3327 fix for CI and local
builds. Users can opt to use a specific release tag with the
ENVOY_PROTOBUF_COMMIT env var.
@htuch htuch merged commit a49b570 into envoyproxy:master Jul 21, 2017
@htuch htuch deleted the protobuf-recipe branch July 21, 2017 17:23
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: noticed this duplication while working on a different PR.
Risk Level: low - identical code, just dispatched as function.
Testing: builds - runs example app with successful headers.

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: noticed this duplication while working on a different PR.
Risk Level: low - identical code, just dispatched as function.
Testing: builds - runs example app with successful headers.

Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake pushed a commit that referenced this pull request Mar 3, 2026
**Description**

Before, there was no feedback at all unless you turn on `--debug`.
Choosing what to enable is difficult as the EG layer creates known
errors that confuse, and our layer we log too much debug as info.

This buys time by making a simple status message and verifying it in
tests.

.e.g.
```bash
$ out/aigw-darwin-arm64 run --mcp-json '{
  "mcpServers": {
    "kiwi": {
      "type": "http",
      "url": "https://mcp.kiwi.com"
    }
  }
}'
Envoy AI Gateway listening on http://localhost:1975 (admin http://localhost:51333) after 16.8s
```

Note, it most importantly only shows when (significantly later) envoy is
actually ready. If you send requests before this, it will fail. Future
PRs can improve logging.


**Related Issues/PRs (if applicable)**

Fixes #1304

---------

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants