Bump github.com/bytedance/sonic to v1.14.0 for Go 1.25 compatibility by stefanb · Pull Request #6348 · projectdiscovery/nuclei

stefanb · 2025-07-27T06:58:27Z

Proposed changes

Fixes #6335
by using https://github.com/bytedance/sonic/releases/tag/v1.14.0

Log:

$ go get github.com/bytedance/sonic@v1.14.0 && go mod tidy
go: upgraded github.com/bytedance/sonic v1.13.3 => v1.14.0
go: upgraded github.com/bytedance/sonic/loader v0.2.4 => v0.3.0

upstream: feat: support go1.25 bytedance/sonic#808
downstream: go 1.25.0, go@1.24 1.24.6 (new formula) Homebrew/homebrew-core#226636

Checklist

Pull request is created against the dev branch
All checks passed (lint, unit/integration/regression tests etc.) with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Summary by CodeRabbit

Chores
- Updated underlying dependencies to improve stability and performance.
- Extended compatibility range for Go versions to support newer releases.

Fixes #6335 by using https://github.com/bytedance/sonic/releases/tag/v1.14.0 $ go get github.com/bytedance/sonic@v1.14.0 && go mod tidy go: upgraded github.com/bytedance/sonic v1.13.3 => v1.14.0 go: upgraded github.com/bytedance/sonic/loader v0.2.4 => v0.3.0

coderabbitai · 2025-07-27T06:58:45Z

Walkthrough

The dependency versions for github.com/bytedance/sonic and its loader submodule were updated in the go.mod file. The main module was upgraded from v1.13.3 to v1.14.0, and the loader from v0.2.4 to v0.3.0. Additionally, the Go version compatibility range in the pkg/utils/json/doc.go documentation was extended to include Go 1.25. No other dependency or code changes were made.

Changes

Cohort / File(s)	Change Summary
Dependency version updates `go.mod`	Upgraded `github.com/bytedance/sonic` from v1.13.3 to v1.14.0 and `sonic/loader` from v0.2.4 to v0.3.0.
Documentation update `pkg/utils/json/doc.go`	Extended Go version compatibility range for the sonic library from "Go >= 1.20 and <= 1.24" to "Go >= 1.20 and <= 1.25".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Fix build failure with Go 1.25 by updating sonic module (#6335)	✅
Ensure compatibility with Go 1.25 in documentation (#6335)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Poem

A hop and a skip, a version anew,
Sonic now faster, its loader fresh too.
With modules updated, the build will not fail,
Go 1.25 support is now on the trail.
The code is still swift, as rabbits prefer,
Just a quick review—no need to confer! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6767116 and d65311d.

📒 Files selected for processing (1)

pkg/utils/json/doc.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

pkg/utils/json/doc.go

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Signed-off-by: Dwi Siswanto <git@dw1.io>

stefanb · 2025-07-28T12:44:43Z

pkg/utils/json/doc.go

 //
 // On supported platforms; Linux, Darwin, or Windows on amd64, or on arm64 with
-// Go >= 1.20 and <= 1.24, the package uses the high-performance [sonic] library.
+// Go >= 1.20 and <= 1.25, the package uses the high-performance [sonic] library.


Thanks, @dwisiswant0 !

…6348) * Bump github.com/bytedance/sonic to v1.14.0 for Go 1.25 compatibility Fixes #6335 by using https://github.com/bytedance/sonic/releases/tag/v1.14.0 $ go get github.com/bytedance/sonic@v1.14.0 && go mod tidy go: upgraded github.com/bytedance/sonic v1.13.3 => v1.14.0 go: upgraded github.com/bytedance/sonic/loader v0.2.4 => v0.3.0 * doc(json): update supported plats Signed-off-by: Dwi Siswanto <git@dw1.io> --------- Signed-off-by: Dwi Siswanto <git@dw1.io> Co-authored-by: Dwi Siswanto <git@dw1.io>

Elsfa7-110 · 2025-08-13T21:47:11Z

go install -v github.com/bytedance/sonic@v1.14.0 && go mod tidy
package github.com/bytedance/sonic is not a main package

go get not working also

auto-assign bot requested a review from dwisiswant0 July 27, 2025 06:58

This was referenced Jul 27, 2025

[BUG] fails to build with Go 1.25 #6335

Closed

go 1.25.0, go@1.24 1.24.6 (new formula) Homebrew/homebrew-core#226636

Merged

doc(json): update supported plats

d65311d

Signed-off-by: Dwi Siswanto <git@dw1.io>

stefanb commented Jul 28, 2025

View reviewed changes

dwisiswant0 approved these changes Jul 28, 2025

View reviewed changes

dwisiswant0 merged commit 91adfeb into projectdiscovery:dev Jul 28, 2025
19 checks passed

stefanb deleted the go-1.25 branch July 28, 2025 12:47

stefanb mentioned this pull request Aug 13, 2025

nuclei: pin go to go@1.24 Homebrew/homebrew-core#233413

Merged

6 tasks

BrewTestBot mentioned this pull request Aug 21, 2025

nuclei 3.4.8 Homebrew/homebrew-core#234422

Merged

blsaccess mentioned this pull request Aug 22, 2025

Update nuclei to 3.4.8 blacklanternsecurity/bbot#2623

Closed

stefanb mentioned this pull request Feb 6, 2026

chore(deps): bump github.com/bytedance/sonic to 1.15.0 for Go 1.26 support #6841

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Bump github.com/bytedance/sonic to v1.14.0 for Go 1.25 compatibility#6348

Bump github.com/bytedance/sonic to v1.14.0 for Go 1.25 compatibility#6348
dwisiswant0 merged 2 commits intoprojectdiscovery:devfrom
stefanb:go-1.25

stefanb commented Jul 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 27, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

stefanb Jul 28, 2025

Uh oh!

Uh oh!

Elsfa7-110 commented Aug 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

stefanb commented Jul 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

stefanb Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Elsfa7-110 commented Aug 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stefanb commented Jul 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)