Add Key Value Storage implementation for EFR32 platform. #4367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2021 09:33
Add a small module which connects pigweed logs to CHIP logging.
Adds support for C++14 KVS.
pullapprove
bot
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
rwalker-apple and
saurabhst
rwalker-apple
approved these changes
Jan 15, 2021
andy31415
approved these changes
Jan 18, 2021
rgoliver
force-pushed
the
kvs_efr
branch
3 times, most recently
from
c11879e to
92fb5c1
Compare
mspang
reviewed
Jan 22, 2021
| size_t offset_bytes) const | ||
| { | ||
| assert(CHIP_KVS_AVAILABLE); | ||
| auto status_and_size = mKvs.Get(key, std::span<std::byte>(reinterpret_cast<std::byte *>(value), value_size), offset_bytes); |
There was a problem hiding this comment.
Isn't std::span C++20 and std::byte C++17?
|
|
||
| pw::StatusWithSize Write(Address destination_flash_address, std::span<const std::byte> data) override | ||
| { | ||
| return pw::StatusWithSize(MscStatusToPwStatus(MSC_WriteWord(reinterpret_cast<uint32_t *>(destination_flash_address), |
There was a problem hiding this comment.
This reinterpret_cast looks like undefined behavior. What if I pass in a span that's not 32 bit aligned?
There was a problem hiding this comment.
This interface is private and only available to the KVS object which is provided the alignment. I'll add some asserts though just in case.
Use the pigweed KVS to implement persitent storage on the EFR32 platform. Only gets included when the application defined the KVS macros.
rgoliver
force-pushed
the
kvs_efr
branch
2 times, most recently
from
0af75e6 to
983f045
Compare
mspang
reviewed
Jan 22, 2021
Add an example app which tests the KVS api.
jelderton
approved these changes
Jan 26, 2021
mspang
approved these changes
Jan 27, 2021
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 28, 2021
…p#4367) * Add pigweed logging backend for CHIP Add a small module which connects pigweed logs to CHIP logging. * Update pigweed repo Adds support for C++14 KVS. * Add KVS implementation for EFR32 platform Use the pigweed KVS to implement persitent storage on the EFR32 platform. Only gets included when the application defined the KVS macros. * Add persistent storage test/example Add an example app which tests the KVS api.
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 28, 2021
…p#4367) * Add pigweed logging backend for CHIP Add a small module which connects pigweed logs to CHIP logging. * Update pigweed repo Adds support for C++14 KVS. * Add KVS implementation for EFR32 platform Use the pigweed KVS to implement persitent storage on the EFR32 platform. Only gets included when the application defined the KVS macros. * Add persistent storage test/example Add an example app which tests the KVS api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add the implementation for the Key Value Storage API on the EFR32 Platform using the pigweed KVS.
Summary of Changes