Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent Storage: move example into a unit test #4406

Closed
rgoliver opened this issue Jan 18, 2021 · 5 comments
Closed

Persistent Storage: move example into a unit test #4406

rgoliver opened this issue Jan 18, 2021 · 5 comments
Labels
examples stale Stale issue or PR storage Involves NVM storage retreival/access testing V1.X
Milestone

Comments

@rgoliver
Copy link

Problem

Reference: #4367

The KVS test is currently a self contained example application, this would be better as a unit test but currently EFR32 does not have a test runner.

Proposed Solution

Once all platforms with Persistent Storage have a test runner, move the example into a unit test.

@kkasperczyk-no
Copy link
Contributor

@rgoliver I have implemented KeyValueStoreManagerImpl on nrfconnect and I need test added to the unit tests to verify if my implementation works well, as I don't plan adding persistent-storage example for nrfconnect. Are you ok with that I will copy example to the unit tests and after all platforms will have test runner, original example will be removed?

@rgoliver
Copy link
Author

@rgoliver I have implemented KeyValueStoreManagerImpl on nrfconnect and I need test added to the unit tests to verify if my implementation works well, as I don't plan adding persistent-storage example for nrfconnect. Are you ok with that I will copy example to the unit tests and after all platforms will have test runner, original example will be removed?

Sounds great, that definitely moves us in the right direction.

@woody-apple
Copy link
Contributor

Moving to post V1.0, not clearly required for V1.0

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 31, 2022
@stale
Copy link

stale bot commented Oct 9, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples stale Stale issue or PR storage Involves NVM storage retreival/access testing V1.X
Projects
None yet
Development

No branches or pull requests

6 participants