Android - implement ChipDnssdStopBrowse #32801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
|
PR #32801: Size comparison from f1abb59 to 3dbf667 Full report (5 builds for cc32xx, linux, mbed)
|
sharadb-amazon
changed the title
bzbarsky-apple
previously requested changes
Apr 1, 2024
|
PR #32801: Size comparison from f1abb59 to 557a1ea Increases (50 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, qpg, telink)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
dismissed
their stale review
The things that made me ask for changes were addressed; the remaining broken bits are Android-specific.
|
PR #32801: Size comparison from f1abb59 to ba9073d Increases above 0.2%:
Increases (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
Decreases (8 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
Fixing style issues cleanup log statement
pgregorr-amazon
force-pushed
the
droid-stop-disc-20240322
branch
from
ba9073d to
77a0459
Compare
|
PR #32801: Size comparison from 0c0c6d6 to 77a0459 Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/platform/android/java/chip/platform/NsdManagerServiceBrowser.java
Outdated
Show resolved
Hide resolved
|
PR #32801: Size comparison from 0c0c6d6 to 0c034a2 Increases above 0.2%:
Increases (5 builds for cc13x4_26x4)
Decreases (2 builds for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
joonhaengHeo
approved these changes
Apr 4, 2024
| return CHIP_ERROR_NOT_IMPLEMENTED; | ||
| VerifyOrReturnError(sBrowserObject.HasValidObjectRef() && sStopBrowseMethod != nullptr, CHIP_ERROR_INVALID_ARGUMENT); | ||
|
|
||
| JNIEnv * env = JniReferences::GetInstance().GetEnvForCurrentThread(); |
There was a problem hiding this comment.
please check whether env is null or not and print error.
| return CHIP_JNI_ERROR_EXCEPTION_THROWN; | ||
| } | ||
| chip::Platform::Delete(ctx); | ||
|
|
There was a problem hiding this comment.
usually we set ctx as null for style.
There was a problem hiding this comment.
Adding ctx = nullptr;
| @@ -81,23 +89,30 @@ public void startDiscover( | |||
| final long contextHandle, | |||
| final ChipMdnsCallback chipMdnsCallback) { | |||
| if (callbackMap.containsKey(callbackHandle)) { | |||
| Log.d(TAG, "Invalid callbackHandle"); | |||
| Log.w(TAG, "Starting service discovery failed. Invalid callbackHandle: " + callbackHandle); | |||
| return; | |||
| } | |||
|
|
|||
| NsdManagerDiscovery discovery = | |||
There was a problem hiding this comment.
please also check whether this new is allocating memory successfully?
examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/CastingPlayerDiscovery-JNI.cpp
Show resolved
Hide resolved
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Apr 16, 2024
This reverts commit 2ca30ac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the implementation for ChipDnssdStopBrowse in connectedhomeip/src/platform/android/DnssdImpl.cpp allowing DNS-SD discovery to be manally stopped before the timeout.
Change summary
Testing
Verified and tested locally with the Android tv-casting-app example app. By calling the stop discovery API form the tv-casting-app app GUI, we are able to stop NsdManagerDiscovery discovery, prior to timeout triggered stop discovery.