Added error checking in Android DnssdImpl.cpp and fixed examples/tv-casting-app bug

[pgregorr-amazon]

This change addresses some comments by yunhanw-google, which were made after a previous PR was merged in. Also fixing an examples/tv-casting-app bug causing the app to crash during connection.

Change summary

1. Added error checking and logging in connectedhomeip/src/platform/android/DnssdImpl.cpp ChipDnssdBrowse and ChipDnssdStopBrowse JNI functions. yunhanw-google left comments on Android - implement ChipDnssdStopBrowse #32801 after it merged in.
2. The example app was crashing after successfully connecting to a CastingPlayer but before transitioning to the next screen. In /tv-casting-app/android/App/app/src/main/java/com/matter/casting/DiscoveryExampleFragment.java. onPause(), removed the call to stopDiscovery(). onPause() is called when transitioning to the next page and stopDiscovery() calls tv-casting-common/core/CastingPlayerDiscovery.cpp StopDiscovery() to clear the list of discovered Casting Players, including the one being connected to.

Testing
Verified and tested locally with the Android tv-casting-app example app. By calling the stop discovery API form the tv-casting-app app GUI, we are able to stop NsdManagerDiscovery discovery, prior to timeout triggered stop discovery. Also able to connect to a d discovered Casting Player.

[yunhanw-google]

thanks

[github-actions]

PR #33010: Size comparison from 90732b2 to 66ff5bf

Decreases (1 build for efr32)

platform	target	config	section	90732b2	66ff5bf	change	% change
efr32	lock-app	BRD4338a	(read/write)	960116	960108	-8	-0.0
			.text	700256	700248	-8	-0.0

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)

platform	target	config	section	90732b2	66ff5bf	change	% change
bl602	lighting-app	bl602	(read/write)	1443066	1443066	0	0.0
			.bss	85440	85440	0	0.0
			.data	9504	9504	0	0.0
			.rodata	159068	159068	0	0.0
			.text	1108398	1108398	0	0.0
		bl602+mfd	(read/write)	1457490	1457490	0	0.0
			.bss	85608	85608	0	0.0
			.data	9480	9480	0	0.0
			.rodata	158028	158028	0	0.0
			.text	1123716	1123716	0	0.0
		bl602+rpc	(read/write)	1490466	1490466	0	0.0
			.bss	93480	93480	0	0.0
			.data	9880	9880	0	0.0
			.rodata	166644	166644	0	0.0
			.text	1139788	1139788	0	0.0
bl702	lighting-app	bl702	(read only)	3478	3478	0	0.0
			(read/write)	1207927	1207927	0	0.0
			.bss	11185	11185	0	0.0
			.data	3696	3696	0	0.0
			.rodata	108432	108432	0	0.0
			.text	977698	977698	0	0.0
		bl702+mfd	(read only)	3478	3478	0	0.0
			(read/write)	1218739	1218739	0	0.0
			.bss	11361	11361	0	0.0
			.data	3672	3672	0	0.0
			.rodata	107372	107372	0	0.0
			.text	989452	989452	0	0.0
		bl702+rpc	(read only)	3478	3478	0	0.0
			(read/write)	1299407	1299407	0	0.0
			.bss	19669	19669	0	0.0
			.data	4232	4232	0	0.0
			.rodata	123804	123804	0	0.0
			.text	1052406	1052406	0	0.0
		bl706-eth	(read/write)	1025193	1025193	0	0.0
			.bss	23760	23760	0	0.0
			.data	3256	3256	0	0.0
			.rodata	101756	101756	0	0.0
			.text	768402	768402	0	0.0
		bl706-wifi	(read/write)	1259858	1259858	0	0.0
			.bss	10645	10645	0	0.0
			.data	3696	3696	0	0.0
			.rodata	122756	122756	0	0.0
			.text	1000292	1000292	0	0.0
bl702l	lighting-app	bl702l	(read only)	512	512	0	0.0
			(read/write)	1177268	1177268	0	0.0
			.bss	16396	16396	0	0.0
			.data	5056	5056	0	0.0
			.rodata	102436	102436	0	0.0
			.text	970564	970564	0	0.0
		bl702l+mfd	(read only)	512	512	0	0.0
			(read/write)	1188676	1188676	0	0.0
			.bss	16572	16572	0	0.0
			.data	5040	5040	0	0.0
			.rodata	101376	101376	0	0.0
			.text	982886	982886	0	0.0
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	(read only)	782812	782812	0	0.0
			(read/write)	171632	171632	0	0.0
			.bss	93588	93588	0	0.0
			.data	3584	3584	0	0.0
			.rodata	82628	82628	0	0.0
			.text	699920	699920	0	0.0
	lock-ftd	LP_EM_CC1354P10_6	(read only)	798796	798796	0	0.0
			(read/write)	182104	182104	0	0.0
			.bss	104076	104076	0	0.0
			.data	3576	3576	0	0.0
			.rodata	76716	76716	0	0.0
			.text	721816	721816	0	0.0
	lock-mtd	LP_EM_CC1354P10_6	(read only)	787564	787564	0	0.0
			(read/write)	176224	176224	0	0.0
			.bss	98196	98196	0	0.0
			.data	3576	3576	0	0.0
			.rodata	103532	103532	0	0.0
			.text	683768	683768	0	0.0
	pump-app	LP_EM_CC1354P10_6	(read only)	739876	739876	0	0.0
			(read/write)	170592	170592	0	0.0
			.bss	92328	92328	0	0.0
			.data	3568	3568	0	0.0
			.rodata	78292	78292	0	0.0
			.text	661320	661320	0	0.0
	pump-controller-app	LP_EM_CC1354P10_6	(read only)	725508	725508	0	0.0
			(read/write)	170816	170816	0	0.0
			.bss	92552	92552	0	0.0
			.data	3568	3568	0	0.0
			.rodata	74068	74068	0	0.0
			.text	651176	651176	0	0.0
cc32xx	air-purifier	CC3235SF_LAUNCHXL	(read only)	586870	586870	0	0.0
			(read/write)	208088	208088	0	0.0
			.bss	201316	201316	0	0.0
			.data	1648	1648	0	0.0
			.rodata	87502	87502	0	0.0
			.text	497244	497244	0	0.0
	lock	CC3235SF_LAUNCHXL	(read only)	631678	631678	0	0.0
			(read/write)	208344	208344	0	0.0
			.bss	201720	201720	0	0.0
			.data	1504	1504	0	0.0
			.rodata	107854	107854	0	0.0
			.text	521704	521704	0	0.0
cyw30739	light	cyw930739m2evb_01	(read/write)	569799	569799	0	0.0
			.app_xip_area	459733	459733	0	0.0
			.bss	64892	64892	0	0.0
			.data	752	752	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	552007	552007	0	0.0
			.app_xip_area	437269	437269	0	0.0
			.bss	69556	69556	0	0.0
			.data	760	760	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	573111	573111	0	0.0
			.app_xip_area	464541	464541	0	0.0
			.bss	63436	63436	0	0.0
			.data	712	712	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	switch	cyw930739m2evb_01	(read/write)	565071	565071	0	0.0
			.app_xip_area	453317	453317	0	0.0
			.bss	66540	66540	0	0.0
			.data	792	792	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4187C	(read/write)	1068472	1068472	0	0.0
			.bss	179896	179896	0	0.0
			.data	3424	3424	0	0.0
			.text	885132	885132	0	0.0
	lock-app	BRD4338a	(read/write)	960116	960108	-8	-0.0
			.bss	210220	210220	0	0.0
			.data	30272	30272	0	0.0
			.text	700256	700248	-8	-0.0
	window-app	BRD4187C	(read/write)	1134308	1134308	0	0.0
			.bss	164496	164496	0	0.0
			.data	3328	3328	0	0.0
			.text	966464	966464	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	1213546	1213546	0	0.0
			(read/write)	1750224	1750224	0	0.0
			.dram0.bss	74320	74320	0	0.0
			.dram0.data	13628	13628	0	0.0
			.flash.rodata	252752	252752	0	0.0
			.flash.text	1213546	1213546	0	0.0
			.iram0.text	75530	75530	0	0.0
		m5stack	(read only)	1256211	1256211	0	0.0
			(read/write)	536532	536532	0	0.0
			.dram0.bss	81064	81064	0	0.0
			.dram0.data	35180	35180	0	0.0
			.flash.rodata	284368	284368	0	0.0
			.flash.text	1250047	1250047	0	0.0
			.iram0.text	125403	125403	0	0.0
linux	air-purifier-app	debug	(read only)	2647093	2647093	0	0.0
			(read/write)	130032	130032	0	0.0
			.bss	46728	46728	0	0.0
			.data	2272	2272	0	0.0
			.data.rel.ro	75080	75080	0	0.0
			.dynamic	608	608	0	0.0
			.got	4520	4520	0	0.0
			.init	27	27	0	0.0
			.init_array	800	800	0	0.0
			.rodata	185392	185392	0	0.0
			.text	2282709	2282709	0	0.0
	all-clusters-app	debug	(read only)	5956769	5956769	0	0.0
			(read/write)	481512	481512	0	0.0
			.bss	135040	135040	0	0.0
			.data	4560	4560	0	0.0
			.data.rel.ro	334472	334472	0	0.0
			.dynamic	624	624	0	0.0
			.got	5328	5328	0	0.0
			.init	27	27	0	0.0
			.init_array	1440	1440	0	0.0
			.rodata	351760	351760	0	0.0
			.text	5170227	5170227	0	0.0
	all-clusters-minimal-app	debug	(read only)	5236697	5236697	0	0.0
			(read/write)	237464	237464	0	0.0
			.bss	127872	127872	0	0.0
			.data	4464	4464	0	0.0
			.data.rel.ro	98056	98056	0	0.0
			.dynamic	624	624	0	0.0
			.got	5248	5248	0	0.0
			.init	27	27	0	0.0
			.init_array	1168	1168	0	0.0
			.rodata	290410	290410	0	0.0
			.text	4710163	4710163	0	0.0
	bridge-app	debug	(read only)	4628561	4628561	0	0.0
			(read/write)	218344	218344	0	0.0
			.bss	118400	118400	0	0.0
			.data	6240	6240	0	0.0
			.data.rel.ro	86976	86976	0	0.0
			.dynamic	624	624	0	0.0
			.got	5216	5216	0	0.0
			.init	27	27	0	0.0
			.init_array	864	864	0	0.0
			.rodata	230794	230794	0	0.0
			.text	4176067	4176067	0	0.0
	chip-tool	debug	(read only)	12084641	12084641	0	0.0
			(read/write)	523104	523104	0	0.0
			.bss	94744	94744	0	0.0
			.data	5122	5122	0	0.0
			.data.rel.ro	416000	416000	0	0.0
			.dynamic	624	624	0	0.0
			.got	5736	5736	0	0.0
			.init	27	27	0	0.0
			.init_array	832	832	0	0.0
			.rodata	451449	451449	0	0.0
			.text	10924835	10924835	0	0.0
	chip-tool-ipv6only	arm64	(read only)	11403972	11403972	0	0.0
			(read/write)	587232	587232	0	0.0
			.bss	103720	103720	0	0.0
			.data	4512	4512	0	0.0
			.data.rel.ro	455936	455936	0	0.0
			.dynamic	512	512	0	0.0
			.got	17112	17112	0	0.0
			.init	24	24	0	0.0
			.init_array	280	280	0	0.0
			.rodata	356260	356260	0	0.0
			.text	10166024	10166024	0	0.0
	lighting-app	debug+rpc+ui	(read only)	5552641	5552641	0	0.0
			(read/write)	227112	227112	0	0.0
			.bss	119344	119344	0	0.0
			.data	4864	4864	0	0.0
			.data.rel.ro	95376	95376	0	0.0
			.dynamic	672	672	0	0.0
			.got	5856	5856	0	0.0
			.init	27	27	0	0.0
			.init_array	976	976	0	0.0
			.rodata	354676	354676	0	0.0
			.text	4949875	4949875	0	0.0
	lock-app	debug	(read only)	4694457	4694457	0	0.0
			(read/write)	205568	205568	0	0.0
			.bss	113704	113704	0	0.0
			.data	4160	4160	0	0.0
			.data.rel.ro	81000	81000	0	0.0
			.dynamic	624	624	0	0.0
			.got	5168	5168	0	0.0
			.init	27	27	0	0.0
			.init_array	880	880	0	0.0
			.rodata	256586	256586	0	0.0
			.text	4225235	4225235	0	0.0
	ota-provider-app	debug	(read only)	4309905	4309905	0	0.0
			(read/write)	194200	194200	0	0.0
			.bss	113440	113440	0	0.0
			.data	4368	4368	0	0.0
			.data.rel.ro	70448	70448	0	0.0
			.dynamic	624	624	0	0.0
			.got	4536	4536	0	0.0
			.init	27	27	0	0.0
			.init_array	752	752	0	0.0
			.rodata	209642	209642	0	0.0
			.text	3905779	3905779	0	0.0
	ota-requestor-app	debug	(read only)	4440721	4440721	0	0.0
			(read/write)	198568	198568	0	0.0
			.bss	114336	114336	0	0.0
			.data	4768	4768	0	0.0
			.data.rel.ro	73536	73536	0	0.0
			.dynamic	624	624	0	0.0
			.got	4472	4472	0	0.0
			.init	27	27	0	0.0
			.init_array	800	800	0	0.0
			.rodata	215914	215914	0	0.0
			.text	4025779	4025779	0	0.0
	shell	debug	(read only)	2923273	2923273	0	0.0
			(read/write)	156880	156880	0	0.0
			.bss	62512	62512	0	0.0
			.data	1424	1424	0	0.0
			.data.rel.ro	87152	87152	0	0.0
			.dynamic	592	592	0	0.0
			.got	4056	4056	0	0.0
			.init	27	27	0	0.0
			.init_array	1112	1112	0	0.0
			.rodata	187872	187872	0	0.0
			.text	2560722	2560722	0	0.0
	thermostat-no-ble	arm64	(read only)	4429100	4429100	0	0.0
			(read/write)	246320	246320	0	0.0
			.bss	121976	121976	0	0.0
			.data	3392	3392	0	0.0
			.data.rel.ro	104296	104296	0	0.0
			.dynamic	512	512	0	0.0
			.got	8712	8712	0	0.0
			.init	24	24	0	0.0
			.init_array	448	448	0	0.0
			.rodata	160148	160148	0	0.0
			.text	3932408	3932408	0	0.0
	tv-app	debug	(read only)	5766793	5766793	0	0.0
			(read/write)	353336	353336	0	0.0
			.bss	244336	244336	0	0.0
			.data	6560	6560	0	0.0
			.data.rel.ro	95160	95160	0	0.0
			.dynamic	624	624	0	0.0
			.got	5464	5464	0	0.0
			.init	27	27	0	0.0
			.init_array	1184	1184	0	0.0
			.rodata	294730	294730	0	0.0
			.text	5228739	5228739	0	0.0
	tv-casting-app	debug	(read only)	9896849	9896849	0	0.0
			(read/write)	342720	342720	0	0.0
			.bss	157976	157976	0	0.0
			.data	3008	3008	0	0.0
			.data.rel.ro	174848	174848	0	0.0
			.dynamic	624	624	0	0.0
			.got	5040	5040	0	0.0
			.init	27	27	0	0.0
			.init_array	1216	1216	0	0.0
			.rodata	384472	384472	0	0.0
			.text	9045571	9045571	0	0.0
mbed	lock-app-release	cy8cproto_062_4343w	(read only)	6224	6224	0	0.0
			(read/write)	2534816	2534816	0	0.0
			.bss	220480	220480	0	0.0
			.data	5216	5216	0	0.0
			.text	1497500	1497500	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1064908	1064908	0	0.0
			bss	133107	133107	0	0.0
			rodata	103052	103052	0	0.0
			text	781528	781528	0	0.0
		nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1225836	1225836	0	0.0
			bss	127163	127163	0	0.0
			rodata	151304	151304	0	0.0
			text	797348	797348	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1012388	1012388	0	0.0
			bss	131965	131965	0	0.0
			rodata	90316	90316	0	0.0
			text	742896	742896	0	0.0
nxp	contact	k32w0+release	(read only)	575116	575116	0	0.0
			(read/write)	80004	80004	0	0.0
			.bss	67840	67840	0	0.0
			.data	2180	2180	0	0.0
			.text	574580	574580	0	0.0
		k32w1+release	(read only)	1024	1024	0	0.0
			(read/write)	702252	702252	0	0.0
			.bss	71184	71184	0	0.0
			.data	2856	2856	0	0.0
			.text	588832	588832	0	0.0
	light	k32w0+release	(read only)	609056	609056	0	0.0
			(read/write)	79464	79464	0	0.0
			.bss	67280	67280	0	0.0
			.data	2200	2200	0	0.0
			.text	608520	608520	0	0.0
		k32w1+release	(read only)	1024	1024	0	0.0
			(read/write)	793992	793992	0	0.0
			.bss	80728	80728	0	0.0
			.data	2056	2056	0	0.0
			.text	671840	671840	0	0.0
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	832288	832288	0	0.0
			(read/write)	1803324	1803324	0	0.0
			.bss	198364	198364	0	0.0
			.data	2688	2688	0	0.0
			.text	1593884	1593884	0	0.0
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	835440	835440	0	0.0
			(read/write)	1725228	1725228	0	0.0
			.bss	195244	195244	0	0.0
			.data	2656	2656	0	0.0
			.text	1518940	1518940	0	0.0
	light	cy8ckit_062s2_43012	(read only)	842168	842168	0	0.0
			(read/write)	1643940	1643940	0	0.0
			.bss	188708	188708	0	0.0
			.data	2464	2464	0	0.0
			.text	1444380	1444380	0	0.0
	lock	cy8ckit_062s2_43012	(read only)	815096	815096	0	0.0
			(read/write)	1672644	1672644	0	0.0
			.bss	215788	215788	0	0.0
			.data	2456	2456	0	0.0
			.text	1446012	1446012	0	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1132368	1132368	0	0.0
			.bss	102572	102572	0	0.0
			.data	844	844	0	0.0
			.text	644752	644752	0	0.0
	lock-app	qpg6105+debug	(read/write)	1092408	1092408	0	0.0
			.bss	97244	97244	0	0.0
			.data	856	856	0	0.0
			.text	604788	604788	0	0.0
stm32	light	STM32WB5MM-DK	(read/write)	603957	603957	0	0.0
			.bss	128428	128428	0	0.0
			.data	676	676	0	0.0
			.rodata	80212	80212	0	0.0
			.text	384896	384896	0	0.0
telink	air-quality-sensor-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	833042	833042	0	0.0
			bss	49836	49836	0	0.0
			text	624068	624068	0	0.0
	all-clusters-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	1096264	1096264	0	0.0
			bss	101520	101520	0	0.0
			text	797616	797616	0	0.0
	all-clusters-minimal-app	tlsr9528a	(read only)	47960	47960	0	0.0
			(read/write)	1057728	1057728	0	0.0
			bss	109968	109968	0	0.0
			text	771974	771974	0	0.0
	bridge-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	913120	913120	0	0.0
			bss	92724	92724	0	0.0
			text	655324	655324	0	0.0
	contact-sensor-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	835078	835078	0	0.0
			bss	49880	49880	0	0.0
			text	626174	626174	0	0.0
	light-switch-app-ota-shell-factory-data	tlsr9528a	(read only)	51584	51584	0	0.0
			(read/write)	935864	935864	0	0.0
			bss	77492	77492	0	0.0
			text	702836	702836	0	0.0
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	(read only)	29122	29122	0	0.0
			(read/write)	1089632	1089632	0	0.0
			bss	99816	99816	0	0.0
			text	793432	793432	0	0.0
	lock-app-dfu	tlsr9528a	(read only)	51584	51584	0	0.0
			(read/write)	910316	910316	0	0.0
			bss	69160	69160	0	0.0
			text	659702	659702	0	0.0
	ota-requestor-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	932908	932908	0	0.0
			bss	92428	92428	0	0.0
			text	674984	674984	0	0.0
	pump-app	tlsr9258a	(read only)	52490	52490	0	0.0
			(read/write)	832732	832732	0	0.0
			bss	58124	58124	0	0.0
			text	623270	623270	0	0.0
	pump-controller-app	tlsr9518adk80d	(read only)	31872	31872	0	0.0
			(read/write)	798852	798852	0	0.0
			bss	56052	56052	0	0.0
			text	598176	598176	0	0.0
	shell	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	676016	676016	0	0.0
			bss	73412	73412	0	0.0
			text	461764	461764	0	0.0
	smoke_co_alarm-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	842802	842802	0	0.0
			bss	51508	51508	0	0.0
			text	632712	632712	0	0.0
	temperature-measurement-app-mars-ota	tlsr9518adk80d	(read only)	32220	32220	0	0.0
			(read/write)	858565	858565	0	0.0
			bss	59676	59676	0	0.0
			text	642278	642278	0	0.0
	thermostat	tlsr9518adk80d	(read only)	31872	31872	0	0.0
			(read/write)	824400	824400	0	0.0
			bss	56384	56384	0	0.0
			text	617728	617728	0	0.0
	window-covering	tlsr9258a	(read only)	52490	52490	0	0.0
			(read/write)	837516	837516	0	0.0
			bss	58340	58340	0	0.0
			text	625636	625636	0	0.0