-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Fix memory leak in DnssdImpl.cpp ChipDnssdStopBrowse() #32855
Merged
sharadb-amazon
merged 2 commits into
project-chip:master
from
pgregorr-amazon:droid-stop-disc-p2-20240404
Apr 4, 2024
Merged
Android: Fix memory leak in DnssdImpl.cpp ChipDnssdStopBrowse() #32855
sharadb-amazon
merged 2 commits into
project-chip:master
from
pgregorr-amazon:droid-stop-disc-p2-20240404
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
April 4, 2024 17:24
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
April 4, 2024 17:24
sharadb-amazon
approved these changes
Apr 4, 2024
PR #32855: Size comparison from cd0e262 to af15c80 Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
bzbarsky-apple
approved these changes
Apr 4, 2024
PR #32855: Size comparison from cd0e262 to 486e009 Decreases (1 build for efr32)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
andy31415
approved these changes
Apr 4, 2024
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Apr 16, 2024
…() (project-chip#32855)" This reverts commit 4cfde10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixing context memory lean in connectedhomeip/src/platform/android/DnssdImpl.cpp ChipDnssdStopBrowse() pointed out by bzbarsky-apple in previous PR 32801 after it merged. Leak would occur if the call to the Java method failed, threw an exception.
Testing
Verified and tested locally with the Android tv-casting-app example app. By calling the stop discovery API form the tv-casting-app app GUI, we are able to stop NsdManagerDiscovery discovery, prior to timeout triggered stop discovery.