-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment regarding why platforms depend on address resolve config #30597
Merged
andy31415
merged 2 commits into
project-chip:master
from
andy31415:less_depend_on_address_resolve_config
Nov 21, 2023
Merged
Add comment regarding why platforms depend on address resolve config #30597
andy31415
merged 2 commits into
project-chip:master
from
andy31415:less_depend_on_address_resolve_config
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
approved these changes
Nov 21, 2023
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
LuDuda,
mhazley and
mspang
November 21, 2023 14:53
pullapprove
bot
requested review from
LuDuda,
mhazley,
mspang,
nivi-apple,
p0fi,
pidarped,
plauric,
robszewczyk,
saurabhst,
sharadb-amazon,
tcarmelveilleux,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
November 21, 2023 14:53
jmartinez-silabs
approved these changes
Nov 21, 2023
PR #30597: Size comparison from a3c5d19 to 003bb5a Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 21, 2023
saurabhst
approved these changes
Nov 21, 2023
DamMicSzm
pushed a commit
to DamMicSzm/connectedhomeip
that referenced
this pull request
Nov 30, 2023
…roject-chip#30597) * Add comment regarding why platforms depend on address resolve config * Restyle --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not have a platform dependency on address_resolve, yet here we are.
Added a comment so that this is not copy & pasted and also so that it is removed in time (I hope) when #30596 is fixed.