[OpenThread] Layering inversion in OpenThread platforms

[andy31415]

Seems to be since #19474:

When CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT is enabled, we have src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp including src/app/Server.h.

The reason it does that is so it runs:

Server::GetInstance().RejoinExistingMulticastGroups();

This makes platform (one of the lowest level things in our code) depend on app (which is the top level thing). We should instead switch to some sort of event system or figure out how to move this RejoinExistingMulticastGroups around to fix dependency.

Sideffect of this is that things like ${chip_root}/src/lib/address_resolve:default_address_resolve_config has to be added to every thread platform (because Server needs address resolution) and we do not want that.

[andy31415]

src/platform/nxp/common/ConfigurationManagerImpl.cpp also seems to have #include <app/server/Server.h> but that may be unrelated ... seems to be the only platform doing that

[andy31415]

❯ rg 'app/server/Server.h' src/platform/
src/platform/nxp/common/ConfigurationManagerImpl.cpp
30:#include <app/server/Server.h>
                                                                                                                                                                                                                                                                               
src/platform/silabs/efr32/wifi/wfx_notify.cpp
44:#include <app/server/Server.h>
                                                                                                                                                                                                                                                                               
src/platform/silabs/SiWx917/wifi/wfx_notify.cpp
37:#include <app/server/Server.h>
                                                                                                                                                                                                                                                                               
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.hpp
69:#include <app/server/Server.h>

These seem to be the wrong inlcudes. OpenThread.hpp needs to be fixed, the others may need case-by-case handling.