Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment regarding why platforms depend on address resolve config #30597

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/platform/Infineon/CYW30739/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ static_library("CYW30739") {
"ThreadStackManagerImpl.cpp",
"ThreadStackManagerImpl.h",
]

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs = [
"${chip_root}/src/lib/address_resolve:default_address_resolve_config",
]
Expand Down
10 changes: 7 additions & 3 deletions src/platform/bouffalolab/BL702/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ static_library("BL702") {
]
deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
}

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}

if (chip_enable_ethernet) {
Expand All @@ -115,7 +122,4 @@ static_library("BL702") {

deps += [ "${chip_root}/src/credentials:credentials_header" ]
public_deps = [ "${chip_root}/src/platform:platform_base" ]

public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}
10 changes: 7 additions & 3 deletions src/platform/bouffalolab/BL702L/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,15 @@ static_library("BL702L") {
]
deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
}

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}

deps += [ "${chip_root}/src/credentials:credentials_header" ]
public_deps = [ "${chip_root}/src/platform:platform_base" ]

public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}
5 changes: 5 additions & 0 deletions src/platform/cc13xx_26xx/cc13x2_26x2/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ static_library("cc13x2_26x2") {
"${chip_root}/src/crypto",
"${chip_root}/src/platform:platform_base",
]

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]

Expand Down
5 changes: 5 additions & 0 deletions src/platform/cc13xx_26xx/cc13x4_26x4/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ static_library("cc13x4_26x4") {
"${chip_root}/src/crypto",
"${chip_root}/src/platform:platform_base",
]

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]

Expand Down
10 changes: 7 additions & 3 deletions src/platform/nxp/k32w/k32w0/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,14 @@ static_library("k32w0") {
]
deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
}

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}

public_deps += [ "${chip_root}/src/crypto" ]

public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}
4 changes: 4 additions & 0 deletions src/platform/nxp/k32w/k32w1/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ static_library("k32w1") {

public_deps += [ "${chip_root}/src/crypto" ]

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs =
[ "${chip_root}/src/lib/address_resolve:default_address_resolve_config" ]
}
5 changes: 4 additions & 1 deletion src/platform/nxp/rt/rw61x/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,10 @@ static_library("nxp_platform") {
public_configs = [
":nxp_platform_config",

# address_resolve config needed by the include of server.h in ConfigurationManagerImpl.cpp
# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
"${chip_root}/src/lib/address_resolve:default_address_resolve_config",
]
}
4 changes: 4 additions & 0 deletions src/platform/qpg/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ static_library("qpg") {
public_deps += [ "${openthread_root}:libopenthread-mtd" ]
}

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs += [
"${chip_root}/third_party/openthread/platforms/qpg:openthread_qpg_config",
"${chip_root}/src/lib/address_resolve:default_address_resolve_config",
Expand Down
4 changes: 4 additions & 0 deletions src/platform/silabs/efr32/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ static_library("efr32") {
deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]
}

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs = [
"${chip_root}/src/lib/address_resolve:default_address_resolve_config",
]
Expand Down
4 changes: 4 additions & 0 deletions src/platform/stm32/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ static_library("stm32") {

deps += [ "${chip_root}/src/lib/dnssd:platform_header" ]

# TODO: platform should NOT depend on default_address_resolve_config. This should
# be removed. See https://github.com/project-chip/connectedhomeip/issues/30596
#
# Currently this exists because OpenThread platform includes src/app/Server.h
public_configs = [
"${chip_root}/src/lib/address_resolve:default_address_resolve_config",
]
Expand Down
Loading