Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing pthread header #22833

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add missing pthread header #22833

merged 1 commit into from
Sep 23, 2022

Conversation

gharveymn
Copy link
Contributor

Issue Being Resolved

Change overview

Adds a missing include of pthread.h to NamedPipeCommands.cpp.

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

PR #22833: Size comparison from edb93a0 to 52e6314

Increases (4 builds for cc13x2_26x2, esp32, telink)
platform target config section edb93a0 52e6314 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676579 676587 8 0.0
.text 586656 586664 8 0.0
pump-controller-app LP_CC2652R7 (read only) 671863 671871 8 0.0
.text 585264 585272 8 0.0
esp32 all-clusters-app c3devkit (read only) 1222918 1222922 4 0.0
.flash.text 1222918 1222922 4 0.0
telink lighting-app tlsr9518adk80d text 592778 592780 2 0.0
Decreases (8 builds for bl702, cc13x2_26x2, nrfconnect, psoc6)
platform target config section edb93a0 52e6314 change % change
bl702 lighting-app bl702 (read/write) 1188091 1188075 -16 -0.0
.debug_info 37898613 37898612 -1 -0.0
.text 956754 956752 -2 -0.0
bl702+rpc .debug_info 41805210 41805209 -1 -0.0
.text 1030456 1030454 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174956 174948 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 177656 177648 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 815296 815292 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26821421 26821420 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26558203 26558201 -2 -0.0
lock cy8ckit_062s2_43012 .debug_info 22401751 22401749 -2 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section edb93a0 52e6314 change % change
bl602 lighting-app bl602 (read/write) 1383286 1383286 0 0.0
.bss 89537 89537 0 0.0
.data 9808 9808 0 0.0
.text 1064948 1064948 0 0.0
bl602+rpc (read/write) 1428498 1428498 0 0.0
.bss 96969 96969 0 0.0
.data 10192 10192 0 0.0
.text 1096296 1096296 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188091 1188075 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4272 4272 0 0.0
.debug_abbrev 1506921 1506921 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486408 486408 0 0.0
.debug_info 37898613 37898612 -1 -0.0
.debug_line 5252753 5252753 0 0.0
.debug_loc 3364043 3364043 0 0.0
.debug_ranges 359032 359032 0 0.0
.debug_str 3456012 3456012 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116472 116472 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564828 564828 0 0.0
.symtab 171600 171600 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956754 956752 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284011 1284011 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644466 1644466 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511784 511784 0 0.0
.debug_info 41805210 41805209 -1 -0.0
.debug_line 5627292 5627292 0 0.0
.debug_loc 3556747 3556747 0 0.0
.debug_ranges 381488 381488 0 0.0
.debug_str 3851912 3851912 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129864 129864 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624001 624001 0 0.0
.symtab 189408 189408 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030456 1030454 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676579 676587 8 0.0
(read/write) 174956 174948 -8 -0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89611 89611 0 0.0
.text 586656 586664 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640835 640835 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78747 0 0.0
.text 561768 561768 0 0.0
lock-ftd LP_CC2652R7 (read only) 678111 678111 0 0.0
(read/write) 170592 170592 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77295 0 0.0
.text 600336 600336 0 0.0
lock-mtd LP_CC2652R7 (read only) 661939 661939 0 0.0
(read/write) 182452 182452 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103131 0 0.0
.text 558328 558328 0 0.0
pump-app LP_CC2652R7 (read only) 687363 687363 0 0.0
(read/write) 162044 162044 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90563 90563 0 0.0
.text 596316 596316 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671863 671871 8 0.0
(read/write) 177656 177648 -8 -0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86119 86119 0 0.0
.text 585264 585272 8 0.0
shell LP_CC2652R7 (read only) 667638 667638 0 0.0
(read/write) 186208 186208 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86326 86326 0 0.0
.text 580996 580996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587306 587306 0 0.0
.app_xip_area 463964 463964 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594370 594370 0 0.0
.app_xip_area 465700 465700 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543378 543378 0 0.0
.app_xip_area 425060 425060 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110504 1110504 0 0.0
.bss 136532 136532 0 0.0
.data 2072 2072 0 0.0
.text 971880 971880 0 0.0
BRD4161A+rpc (read/write) 973676 973676 0 0.0
.bss 151044 151044 0 0.0
.data 2252 2252 0 0.0
.text 820360 820360 0 0.0
BRD4161A+rs911x (read/write) 1003768 1003768 0 0.0
.bss 169368 169368 0 0.0
.data 2064 2064 0 0.0
.text 832316 832316 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151332 1151332 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996992 996992 0 0.0
window-app BRD4161A (read/write) 1102560 1102560 0 0.0
.bss 137980 137980 0 0.0
.data 2096 2096 0 0.0
.text 962464 962464 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222918 1222922 4 0.0
(read/write) 1788078 1788078 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257648 257648 0 0.0
.flash.text 1222918 1222922 4 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233031 1233031 0 0.0
(read/write) 563980 563980 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314712 314712 0 0.0
.flash.text 1227647 1227647 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649908 649908 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574400 574400 0 0.0
lock k32w0+release (read/write) 706864 706864 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630900 630900 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10381740 10381740 0 0.0
(read/write) 706257 706257 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 508332 508332 0 0.0
.text 8219428 8219428 0 0.0
thermostat-no-ble arm64 (read only) 2387508 2387508 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143676 143676 0 0.0
.text 2001536 2001536 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455680 2455680 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418324 1418324 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182875 1182875 0 0.0
bss 144433 144433 0 0.0
rodata 144236 144236 0 0.0
text 815296 815292 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161559 1161559 0 0.0
bss 143660 143660 0 0.0
rodata 135808 135808 0 0.0
text 803188 803188 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1744324 1744324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229470 1229470 0 0.0
.debug_aranges 111824 111824 0 0.0
.debug_frame 373360 373360 0 0.0
.debug_info 26821421 26821420 -1 -0.0
.debug_line 3668982 3668982 0 0.0
.debug_loc 3583230 3583230 0 0.0
.debug_ranges 338856 338856 0 0.0
.debug_str 3439777 3439777 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569480 569480 0 0.0
.symtab 421024 421024 0 0.0
.text 1544560 1544560 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1686932 1686932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221269 1221269 0 0.0
.debug_aranges 111296 111296 0 0.0
.debug_frame 376440 376440 0 0.0
.debug_info 26558203 26558201 -2 -0.0
.debug_line 3689698 3689698 0 0.0
.debug_loc 3570867 3570867 0 0.0
.debug_ranges 337472 337472 0 0.0
.debug_str 3428790 3428790 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533569 533569 0 0.0
.symtab 407456 407456 0 0.0
.text 1487904 1487904 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1605452 1605452 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055325 1055325 0 0.0
.debug_aranges 103504 103504 0 0.0
.debug_frame 346768 346768 0 0.0
.debug_info 22022384 22022384 0 0.0
.debug_line 3259618 3259618 0 0.0
.debug_loc 3268931 3268931 0 0.0
.debug_ranges 302800 302800 0 0.0
.debug_str 3234322 3234322 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469946 469946 0 0.0
.symtab 375904 375904 0 0.0
.text 1414616 1414616 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845864 845864 0 0.0
(read/write) 1643332 1643332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062744 1062744 0 0.0
.debug_aranges 104176 104176 0 0.0
.debug_frame 349592 349592 0 0.0
.debug_info 22401751 22401749 -2 -0.0
.debug_line 3268332 3268332 0 0.0
.debug_loc 3308774 3308774 0 0.0
.debug_ranges 306144 306144 0 0.0
.debug_str 3261777 3261777 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476186 476186 0 0.0
.symtab 379136 379136 0 0.0
.text 1447464 1447464 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146288 1146288 0 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593384 593384 0 0.0
lock-app qpg6105+debug (read/write) 1116180 1116180 0 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563280 563280 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814512 814512 0 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574560 574560 0 0.0
lighting-app tlsr9518adk80d (read/write) 836616 836616 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592778 592780 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844576 844576 0 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598962 598962 0 0.0

@andy31415 andy31415 merged commit efb8f2f into project-chip:master Sep 23, 2022
emargolis pushed a commit to emargolis/connectedhomeip-1 that referenced this pull request Oct 17, 2022
@gharveymn @emargolis
Add missing pthread header (project-chip#22833)
b8743d1
@emargolis emargolis mentioned this pull request Oct 17, 2022
Merged
andy31415 added a commit that referenced this pull request Oct 20, 2022
@emargolis @gharveymn
@turon @vivien-apple @tcarmelveilleux @andy31415
[SVE2] Cherry Pick Matter Official CDs and CD Trusted Storage Impleme…
96c9357 
…ntation (#23239)

* Add missing pthread header (#22833)

* [build] Fix #21255 - allow circular initialization of SimpleStateMachine test. (#22461)

* [build] Fix #21255 - allow circular initialization of SimpleStateMachine test.

* [build] Add comment per review feedback.

* [Darwin][AttestationVerifier] Expose a mechanism to customise cd signing keys and use it in darwin (#22338)

* Add AttestationTrustStore::GetCertificationDeclarationCert virtual method to allow controllers passing in some CD certs

* Add cdCerts member to MTRControllerFactoryparams and override AttestationTrustStore::GetCertificationDeclarationCert

* Implement ArrayTrustStore::GetCertificationDeclarationSigningKey and initialize the test ArrayTrustStore store with the test CD cert

* Update the FileAttestationTrustStore to read a directory with der certs for certification declaration verification

* Add credentials/development/cd-certs/ and update chip-tool to use it if desired

* Update API to match conversation
- Remove CD stuff from FileAttestationTrustStore
- Refactor FileAttestationTrustStore to allow loading
  of any X.509 cert directory
- Add a command line to chip-tool to disallow test keys
  (`only-allow-trusted-cd-keys`)
- Add plumbing to enable CD keys lookup properly without mixing-up
  with PAA semantics
- Add official CD verifying key and official SDK CD test key
  in the default CD trust store as-is

* Update src/darwin to take into account the proposed changes

* Add unit test for `CsaCdKeysTrustStore`

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

* [Attestation] Updated to Use CD Signed by a Valid CSA Cert (#22685)

* Updated CSA Official CD Signing Certificates (#23027)

* restyled.

* Remove fixed versioning for git in cirque (#23257)

Co-authored-by: Gene Harvey <[email protected]>
Co-authored-by: Martin Turon <[email protected]>
Co-authored-by: Vivien Nicolas <[email protected]>
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Linux build failure from missing pthread header
3 participants
@gharveymn @andy31415 @bzbarsky-apple