Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Attestation] Updated to Use CD Signed by a Valid CSA Cert #22685

Merged
merged 1 commit into from
Sep 16, 2022
Merged

[Attestation] Updated to Use CD Signed by a Valid CSA Cert #22685

merged 1 commit into from
Sep 16, 2022

Conversation

emargolis
Copy link
Contributor

Issue Being Resolved

#22428

Change overview

Replaced test CD with valid CD signed by official CD Signing Certificate

@github-actions
Copy link

github-actions bot commented Sep 15, 2022 •
edited
Loading

PR #22685: Size comparison from 003fc60 to ee1ee50

Increases above 0.2%:

platform target config section 003fc60 ee1ee50 change % change
linux thermostat-no-ble arm64 (read only) 2368828 2385916 17088 0.7
(read/write) 142545 143457 912 0.6
.data 1704 1912 208 12.2
.data.rel.ro 76704 77112 408 0.5
.got 5096 5160 64 1.3
.init_array 416 432 16 3.8
.rodata 141748 143492 1744 1.2
.text 1987984 2000416 12432 0.6
Increases (13 builds for bl702, cc13x2_26x2, linux, psoc6, qpg, telink)
platform target config section 003fc60 ee1ee50 change % change
bl702 lighting-app bl702 .debug_loc 3363571 3363577 6 0.0
bl702+rpc .debug_info 41800620 41800621 1 0.0
.debug_loc 3556239 3556245 6 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174900 174908 8 0.0
lock-ftd LP_CC2652R7 (read/write) 163672 163680 8 0.0
lock-mtd LP_CC2652R7 (read/write) 175532 175540 8 0.0
pump-app LP_CC2652R7 (read/write) 155140 155148 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 170768 170776 8 0.0
linux chip-tool-ipv6only arm64 .text 8195268 8195332 64 0.0
thermostat-no-ble arm64 (read only) 2368828 2385916 17088 0.7
(read/write) 142545 143457 912 0.6
.bss 55249 55297 48 0.1
.data 1704 1912 208 12.2
.data.rel.ro 76704 77112 408 0.5
.got 5096 5160 64 1.3
.init_array 416 432 16 3.8
.rodata 141748 143492 1744 1.2
.text 1987984 2000416 12432 0.6
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 26815346 26815347 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26552194 26552196 2 0.0
qpg lock-app qpg6105+debug (read/write) 1101880 1101888 8 0.0
.text 548980 548988 8 0.0
telink ota-requestor-app tlsr9518adk80d text 599110 599112 2 0.0
Decreases (24 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, psoc6, telink)
platform target config section 003fc60 ee1ee50 change % change
bl602 lighting-app bl602 (read/write) 1412934 1412922 -12 -0.0
.text 1067652 1067644 -8 -0.0
bl602+rpc (read/write) 1458402 1458390 -12 -0.0
.text 1099256 1099248 -8 -0.0
bl702 lighting-app bl702 (read/write) 1188443 1188427 -16 -0.0
.rodata 116504 116488 -16 -0.0
.text 957196 957188 -8 -0.0
bl702+rpc (read/write) 1284371 1284355 -16 -0.0
.text 1030898 1030892 -6 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676515 676507 -8 -0.0
.rodata 89595 89587 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640771 640763 -8 -0.0
.rodata 78747 78739 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 678063 678055 -8 -0.0
.rodata 77295 77287 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 661891 661883 -8 -0.0
.rodata 103131 103123 -8 -0.0
pump-app LP_CC2652R7 (read only) 687299 687291 -8 -0.0
.rodata 90563 90555 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671775 -8 -0.0
.rodata 86119 86111 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587458 587450 -8 -0.0
.app_xip_area 464116 464108 -8 -0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543506 543498 -8 -0.0
.app_xip_area 425188 425180 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973620 973612 -8 -0.0
.text 820504 820496 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1151492 1151484 -8 -0.0
.text 997152 997144 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 563980 563972 -8 -0.0
.flash.rodata 314712 314704 -8 -0.0
k32w light k32w0+release (read/write) 650004 649996 -8 -0.0
.text 574496 574488 -8 -0.0
lock k32w0+release (read/write) 706960 706952 -8 -0.0
.text 630996 630988 -8 -0.0
linux chip-tool-ipv6only arm64 .rodata 503924 503860 -64 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1744324 1744316 -8 -0.0
.debug_line 3669159 3669157 -2 -0.0
.text 1544560 1544552 -8 -0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1686964 1686956 -8 -0.0
.debug_line 3689875 3689873 -2 -0.0
.text 1487936 1487928 -8 -0.0
light cy8ckit_062s2_43012 .debug_info 22017631 22017630 -1 -0.0
.debug_line 3259887 3259885 -2 -0.0
lock cy8ckit_062s2_43012 .debug_info 22396951 22396950 -1 -0.0
.debug_line 3268581 3268579 -2 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813860 -8 -0.0
lighting-app tlsr9518adk80d (read/write) 835824 835816 -8 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 003fc60 ee1ee50 change % change
bl602 lighting-app bl602 (read/write) 1412934 1412922 -12 -0.0
.bss 121585 121585 0 0.0
.data 9824 9824 0 0.0
.text 1067652 1067644 -8 -0.0
bl602+rpc (read/write) 1458402 1458390 -12 -0.0
.bss 129017 129017 0 0.0
.data 10208 10208 0 0.0
.text 1099256 1099248 -8 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188443 1188427 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66958 66958 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506733 1506733 0 0.0
.debug_aranges 133072 133072 0 0.0
.debug_frame 486352 486352 0 0.0
.debug_info 37894050 37894050 0 0.0
.debug_line 5253364 5253364 0 0.0
.debug_loc 3363571 3363577 6 0.0
.debug_ranges 360232 360232 0 0.0
.debug_str 3455343 3455343 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116504 116488 -16 -0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957196 957188 -8 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284371 1284355 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75006 75006 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644312 1644312 0 0.0
.debug_aranges 140576 140576 0 0.0
.debug_frame 511728 511728 0 0.0
.debug_info 41800620 41800621 1 0.0
.debug_line 5627903 5627903 0 0.0
.debug_loc 3556239 3556245 6 0.0
.debug_ranges 382688 382688 0 0.0
.debug_str 3851310 3851310 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030898 1030892 -6 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676515 676507 -8 -0.0
(read/write) 174900 174908 8 0.0
.bss 74308 74308 0 0.0
.data 3380 3380 0 0.0
.rodata 89595 89587 -8 -0.0
.text 586608 586608 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640771 640763 -8 -0.0
(read/write) 157876 157876 0 0.0
.bss 73580 73580 0 0.0
.data 3380 3380 0 0.0
.rodata 78747 78739 -8 -0.0
.text 561704 561704 0 0.0
lock-ftd LP_CC2652R7 (read only) 678063 678055 -8 -0.0
(read/write) 163672 163680 8 0.0
.bss 71516 71516 0 0.0
.data 3304 3304 0 0.0
.rodata 77295 77287 -8 -0.0
.text 600288 600288 0 0.0
lock-mtd LP_CC2652R7 (read only) 661891 661883 -8 -0.0
(read/write) 175532 175540 8 0.0
.bss 67204 67204 0 0.0
.data 3304 3304 0 0.0
.rodata 103131 103123 -8 -0.0
.text 558280 558280 0 0.0
pump-app LP_CC2652R7 (read only) 687299 687291 -8 -0.0
(read/write) 155140 155148 8 0.0
.bss 71452 71452 0 0.0
.data 3296 3296 0 0.0
.rodata 90563 90555 -8 -0.0
.text 596252 596252 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671783 671775 -8 -0.0
(read/write) 170768 170776 8 0.0
.bss 71564 71564 0 0.0
.data 3292 3292 0 0.0
.rodata 86119 86111 -8 -0.0
.text 585184 585184 0 0.0
shell LP_CC2652R7 (read only) 667518 667518 0 0.0
(read/write) 179408 179408 0 0.0
.bss 76620 76620 0 0.0
.data 3376 3376 0 0.0
.rodata 86302 86302 0 0.0
.text 580900 580900 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587458 587450 -8 -0.0
.app_xip_area 464116 464108 -8 -0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594514 594514 0 0.0
.app_xip_area 465844 465844 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543506 543498 -8 -0.0
.app_xip_area 425188 425180 -8 -0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110784 1110784 0 0.0
.bss 136332 136332 0 0.0
.data 2072 2072 0 0.0
.text 972360 972360 0 0.0
BRD4161A+rpc (read/write) 973620 973612 -8 -0.0
.bss 150844 150844 0 0.0
.data 2252 2252 0 0.0
.text 820504 820496 -8 -0.0
BRD4161A+rs911x (read/write) 1004032 1004032 0 0.0
.bss 169168 169168 0 0.0
.data 2064 2064 0 0.0
.text 832780 832780 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151492 1151484 -8 -0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 997152 997144 -8 -0.0
window-app BRD4161A (read/write) 1102832 1102832 0 0.0
.bss 137780 137780 0 0.0
.data 2096 2096 0 0.0
.text 962936 962936 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223050 1223050 0 0.0
(read/write) 1788086 1788086 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257656 257656 0 0.0
.flash.text 1223050 1223050 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1233111 1233111 0 0.0
(read/write) 563980 563972 -8 -0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314712 314704 -8 -0.0
.flash.text 1227727 1227727 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 650004 649996 -8 -0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574496 574488 -8 -0.0
lock k32w0+release (read/write) 706960 706952 -8 -0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630996 630988 -8 -0.0
linux chip-tool-ipv6only arm64 (read only) 10353140 10353140 0 0.0
(read/write) 706241 706241 0 0.0
.bss 33937 33937 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13904 13904 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 503924 503860 -64 -0.0
.text 8195268 8195332 64 0.0
thermostat-no-ble arm64 (read only) 2368828 2385916 17088 0.7
(read/write) 142545 143457 912 0.6
.bss 55249 55297 48 0.1
.data 1704 1912 208 12.2
.data.rel.ro 76704 77112 408 0.5
.dynamic 560 560 0 0.0
.got 5096 5160 64 1.3
.init 24 24 0 0.0
.init_array 416 432 16 3.8
.rodata 141748 143492 1744 1.2
.text 1987984 2000416 12432 0.6
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455808 2455808 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418452 1418452 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182191 1182191 0 0.0
bss 143633 143633 0 0.0
rodata 144224 144224 0 0.0
text 815384 815384 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1160863 1160863 0 0.0
bss 142860 142860 0 0.0
rodata 135816 135816 0 0.0
text 803252 803252 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1744324 1744316 -8 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229321 1229321 0 0.0
.debug_aranges 111784 111784 0 0.0
.debug_frame 373216 373216 0 0.0
.debug_info 26815346 26815347 1 0.0
.debug_line 3669159 3669157 -2 -0.0
.debug_loc 3582858 3582858 0 0.0
.debug_ranges 340664 340664 0 0.0
.debug_str 3438974 3438974 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569356 569356 0 0.0
.symtab 421168 421168 0 0.0
.text 1544560 1544552 -8 -0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1686964 1686956 -8 -0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221120 1221120 0 0.0
.debug_aranges 111256 111256 0 0.0
.debug_frame 376296 376296 0 0.0
.debug_info 26552194 26552196 2 0.0
.debug_line 3689875 3689873 -2 -0.0
.debug_loc 3570495 3570495 0 0.0
.debug_ranges 339280 339280 0 0.0
.debug_str 3427987 3427987 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533445 533445 0 0.0
.symtab 407600 407600 0 0.0
.text 1487936 1487928 -8 -0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850896 850896 0 0.0
(read/write) 1605540 1605540 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055176 1055176 0 0.0
.debug_aranges 103464 103464 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22017631 22017630 -1 -0.0
.debug_line 3259887 3259885 -2 -0.0
.debug_loc 3268799 3268799 0 0.0
.debug_ranges 304608 304608 0 0.0
.debug_str 3233519 3233519 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 469822 469822 0 0.0
.symtab 376048 376048 0 0.0
.text 1414704 1414704 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845864 845864 0 0.0
(read/write) 1643148 1643148 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062595 1062595 0 0.0
.debug_aranges 104136 104136 0 0.0
.debug_frame 349448 349448 0 0.0
.debug_info 22396951 22396950 -1 -0.0
.debug_line 3268581 3268579 -2 -0.0
.debug_loc 3308657 3308657 0 0.0
.debug_ranges 307952 307952 0 0.0
.debug_str 3260974 3260974 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476025 476025 0 0.0
.symtab 379232 379232 0 0.0
.text 1447280 1447280 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1130924 1130924 0 0.0
.bss 106112 106112 0 0.0
.data 1028 1028 0 0.0
.text 578020 578020 0 0.0
lock-app qpg6105+debug (read/write) 1101880 1101888 8 0.0
.bss 102344 102344 0 0.0
.data 1032 1032 0 0.0
.text 548980 548988 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 813868 813860 -8 -0.0
bss 71372 71372 0 0.0
noinit 43488 43488 0 0.0
text 574710 574710 0 0.0
lighting-app tlsr9518adk80d (read/write) 835824 835816 -8 -0.0
bss 72228 72228 0 0.0
noinit 43488 43488 0 0.0
text 592870 592870 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 843916 843916 0 0.0
bss 73136 73136 0 0.0
noinit 43488 43488 0 0.0
text 599110 599112 2 0.0

@andy31415 andy31415 merged commit 5fae178 into project-chip:master Sep 16, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@emargolis @isiu-apple
[Attestation] Updated to Use CD Signed by a Valid CSA Cert (project-c…
5d3ffbf 
…hip#22685)
@emargolis emargolis mentioned this pull request Sep 23, 2022
Closed
emargolis added a commit to emargolis/connectedhomeip-1 that referenced this pull request Oct 17, 2022
@emargolis
[Attestation] Updated to Use CD Signed by a Valid CSA Cert (project-c…
35d6d72 
…hip#22685)
@emargolis emargolis mentioned this pull request Oct 17, 2022
Merged
andy31415 added a commit that referenced this pull request Oct 20, 2022
@emargolis @gharveymn
@turon @vivien-apple @tcarmelveilleux @andy31415
[SVE2] Cherry Pick Matter Official CDs and CD Trusted Storage Impleme…
96c9357 
…ntation (#23239)

* Add missing pthread header (#22833)

* [build] Fix #21255 - allow circular initialization of SimpleStateMachine test. (#22461)

* [build] Fix #21255 - allow circular initialization of SimpleStateMachine test.

* [build] Add comment per review feedback.

* [Darwin][AttestationVerifier] Expose a mechanism to customise cd signing keys and use it in darwin (#22338)

* Add AttestationTrustStore::GetCertificationDeclarationCert virtual method to allow controllers passing in some CD certs

* Add cdCerts member to MTRControllerFactoryparams and override AttestationTrustStore::GetCertificationDeclarationCert

* Implement ArrayTrustStore::GetCertificationDeclarationSigningKey and initialize the test ArrayTrustStore store with the test CD cert

* Update the FileAttestationTrustStore to read a directory with der certs for certification declaration verification

* Add credentials/development/cd-certs/ and update chip-tool to use it if desired

* Update API to match conversation
- Remove CD stuff from FileAttestationTrustStore
- Refactor FileAttestationTrustStore to allow loading
  of any X.509 cert directory
- Add a command line to chip-tool to disallow test keys
  (`only-allow-trusted-cd-keys`)
- Add plumbing to enable CD keys lookup properly without mixing-up
  with PAA semantics
- Add official CD verifying key and official SDK CD test key
  in the default CD trust store as-is

* Update src/darwin to take into account the proposed changes

* Add unit test for `CsaCdKeysTrustStore`

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

* [Attestation] Updated to Use CD Signed by a Valid CSA Cert (#22685)

* Updated CSA Official CD Signing Certificates (#23027)

* restyled.

* Remove fixed versioning for git in cirque (#23257)

Co-authored-by: Gene Harvey <[email protected]>
Co-authored-by: Martin Turon <[email protected]>
Co-authored-by: Vivien Nicolas <[email protected]>
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emargolis @andy31415 @woody-apple