This repository was archived by the owner on Jul 5, 2024. It is now read-only.
spec for opcode COINBASE#83
Merged
Merged
Conversation
ChihChengLiang
approved these changes
Jan 4, 2022
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM, added some nitpicks
han0110
reviewed
Jan 5, 2022
| gas_limit: U64 | ||
| block_number: U256 | ||
| time: U256 | ||
| time: U64 |
Contributor
There was a problem hiding this comment.
Using u64 makes more sense after I saw the actual date of the max uint64 as unix time. Would you mind update the table_assignments of it to use raw value self.time instead of random liinear combination? (in line 45)
Let's discuss how they should exist in table in the #75 thread.
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
Contributor
|
Should we merge this @han0110 ? |
han0110
reviewed
Jan 12, 2022
han0110
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.