This repository was archived by the owner on Jul 5, 2024. It is now read-only.
revise log id for look up#214
Merged
Merged
Conversation
Collaborator
Author
|
@ed255 could you pls. have a look ? thx ! |
8 tasks
ed255
approved these changes
Jun 2, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the update!
This was referenced Jun 30, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two minor changes:
the reason is only in next copy step, log_id plus 1, while current step log_id is zero, however, for the semantic matter, they are belong to the same real step of evm/geth, so both use next step log_id is reasonable for lookup, which also matched pre defined zero log id meaning no log data executed.