feat: add sload op (bus-mapping version)#347
Conversation
|
Can we also rebase and squash some commits for reviewability? |
|
If it's not ready for review also, can we set it as WIP? And put the PR as draft? |
|
It can be reviewed. it's just a different version of #334 and I am not sure which version is preferred. But if "rebase/squash" before review is preferable as @ChihChengLiang suggests, I can turn it to WIP or draft. |
So we should review both and decide? What do they differ on? That PR will allow to build the tests you need. |
Sounds good, I will close this for now. |
privacy-ethereum/zkevm-specs#106
Notes:
sstoreare more complicated.sloadop (non-bus-mapping version) #334Since the bus-mapping version tests cannot really cover 1)
is_warm2)revertedcases, I just keep both "bus-mapping" and "handwrite rw_table" versions.