Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Exponentiation circuit and EXP opcode#700

Merged
roynalnaruto merged 53 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/exp
Oct 31, 2022
Merged

Exponentiation circuit and EXP opcode#700
roynalnaruto merged 53 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/exp

Conversation

@roynalnaruto
Copy link
Copy Markdown
Collaborator

@roynalnaruto roynalnaruto commented Aug 19, 2022 •
edited
Loading

@github-actions github-actions Bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements crate-bus-mapping Issues related to the bus-mapping workspace member labels Aug 19, 2022
@roynalnaruto roynalnaruto changed the title EXP opcode gadget, Exponentiation circuit/table Exponentiation circuit and EXP opcode Aug 24, 2022
@roynalnaruto roynalnaruto force-pushed the feat/exp branch 3 times, most recently from e734b6c to 55f63cb Compare September 2, 2022 11:10
@roynalnaruto roynalnaruto force-pushed the feat/exp branch 2 times, most recently from aadcfa3 to 3b75189 Compare September 8, 2022 06:10
@roynalnaruto roynalnaruto mentioned this pull request Sep 13, 2022
Merged
3 tasks
@roynalnaruto roynalnaruto marked this pull request as ready for review September 13, 2022 14:15
JohnWick2ETH
JohnWick2ETH reviewed Sep 14, 2022
View reviewed changes
Comment thread zkevm-circuits/src/evm_circuit/execution/exp.rs Outdated
Comment thread zkevm-circuits/src/evm_circuit/execution/exp.rs Outdated
Comment thread zkevm-circuits/src/evm_circuit/execution/exp.rs
JohnWick2ETH
JohnWick2ETH reviewed Sep 14, 2022
View reviewed changes
Comment thread zkevm-circuits/src/exp_circuit.rs
Comment thread zkevm-circuits/src/exp_circuit.rs Outdated
@roynalnaruto roynalnaruto requested review from a team, JohnWick2ETH and ed255 and removed request for a team September 14, 2022 15:32
JohnWick2ETH
JohnWick2ETH reviewed Sep 15, 2022
View reviewed changes
Comment thread zkevm-circuits/src/exp_circuit.rs Outdated
Comment thread zkevm-circuits/src/exp_circuit.rs Outdated
@OrestTa
Copy link
Copy Markdown

OrestTa commented Sep 15, 2022

For future reference again: Design document at https://hackmd.io/@rohitnarurkar/BJhpYGiCc

@lispc
Copy link
Copy Markdown
Collaborator

lispc commented Sep 27, 2022

@roynalnaruto it seems the zkevm-circuits/src/evm_circuit/witness.rs here may not be correct. This witness.rs has already been deleted and splited into several smaller files. https://github.com/privacy-scaling-explorations/zkevm-circuits/tree/main/zkevm-circuits/src/witness

@roynalnaruto
Copy link
Copy Markdown
Collaborator Author

roynalnaruto commented Oct 13, 2022

@lispc removed the evm_circuit/witness.rs in favour of the new witness module.

@roynalnaruto roynalnaruto requested review from adria0 and lispc and removed request for JohnWick2ETH October 20, 2022 06:55
roynalnaruto and others added 18 commits October 28, 2022 14:09
@roynalnaruto
fix: identifier | is_pad constraints, 2*n + k parity check using mul …
88eb8ff 
…gadget
@roynalnaruto
tests: add the previously failing test, verify that parity check is OK
c1be5e6
@roynalnaruto
fix: remove redundant column (not used anymore)
4a76a45
@roynalnaruto
chore: rename field to concise
cf68169
@roynalnaruto
fix: assignment to exp table matches exp circuit block assignment
ca81b6c
@roynalnaruto
fix: is_pad added to lookup, no need for mul gadget in exp gadget
972573e
@roynalnaruto
fix: no overflow in parity check gadget
1b1a3ed
@roynalnaruto
fix: exp circuit layout
7b6ea7e
@roynalnaruto
fix: compilation after rebase
feddd4f
@lispc @roynalnaruto
fix negative tests
e8246ce
@roynalnaruto
remove redundant addition
0a9c5e6
@roynalnaruto
fix: c == 0 and is_last bool check
7e5c4f2
@roynalnaruto @adria0
fix: comment on the correct line
184cb67 
Co-authored-by: adria0.eth <5526331+adria0@users.noreply.github.com>
@roynalnaruto
fix: formatting
1f4b28f
@roynalnaruto
fix: uncomment tests
952ff32
@roynalnaruto
refactoring for better encapsulation
621e0d2
@roynalnaruto
fix: avoid conditional assignment
9b68cb3
@roynalnaruto
chore: rebase and fmt
e7a65f1
@roynalnaruto roynalnaruto mentioned this pull request Oct 31, 2022
Merged
ChihChengLiang
ChihChengLiang reviewed Oct 31, 2022
View reviewed changes
Comment thread zkevm-circuits/src/evm_circuit/execution/exp.rs
Comment thread zkevm-circuits/src/evm_circuit/execution/exp.rs Outdated
ChihChengLiang
ChihChengLiang approved these changes Oct 31, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great PR!

@roynalnaruto roynalnaruto merged commit 247bcff into privacy-ethereum:main Oct 31, 2022
@roynalnaruto roynalnaruto deleted the feat/exp branch October 31, 2022 11:12
lispc pushed a commit that referenced this pull request Aug 3, 2023
@noel2004
opt min_num_rows_block in poseidon_circuit (#700)
aa177c0 
prune debug prints and lint
lispc added a commit that referenced this pull request Aug 28, 2023
@zhenfeizhang @lightsing
@noel2004 @lispc @kunxian-xia @silathdiir
#711 + #713 remove num chunks from public input; relax the constraint…
8f3e82a 
…s for the dummy chunk proofs to avoid dummy chunk proofgen time (#712)

* partiall address review comments of #670

* disable disable_proof_agg by default

* fix soundness issues with data hash

* add fixed cells for chunk_is_valid

* fix typo

* well... need morning coffee

* typo in readme

* fix soundness issue in is_smaller_than

* [feat] unify u8 u16 lookup table (#694)

* add range table

* replace Range256Table of rlp_circuit_fsm

* replace u16_table of tx_circuit

* use TableColumn

* add type alias

* use type alias

* annotate lookup column

* opt min_num_rows_block in poseidon_circuit (#700)

prune debug prints and lint

* speedup ci using verify_at_rows (#703)

* speedup ci using verify_at_rows

* use verify_at_rows to speedup super circuit ci tests

* update super circuit row estimation API (#695)

* remove num_of_chunks in aggregation circuit's instance column (#704)

Co-authored-by: kunxian xia <xiakunxian130@gmail.com>

* fix: lost tx_type when doing type conversion (#710)

* fix condition (#708)

* gates for zero checks

* statement 1 is correct

* reenable statements 3,6,7

* reenable statement 4

* everything seems to work again

* update aggregation test accordingly

* update spec

* minor clean up

* Fix fmt.

* Make `ChunkHash` fields public.

* fix decompose function

* update figures

* clean up

* address comments

* add is_final checks

* update readme

* constraint hash input length

* fix clippy

---------

Co-authored-by: Akase Cho <lightsing@users.noreply.github.com>
Co-authored-by: Ho <noel.wei@gmail.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: kunxian xia <xiakunxian130@gmail.com>
Co-authored-by: Steven Gu <asongala@163.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ed255 ed255 Awaiting requested review from ed255

@lispc lispc Awaiting requested review from lispc

@icemelon icemelon Awaiting requested review from icemelon

@JohnWick2ETH JohnWick2ETH Awaiting requested review from JohnWick2ETH

2 more reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@adria0 adria0 adria0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-gadgets Issues related to the gadgets workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@roynalnaruto @OrestTa @lispc @adria0 @ChihChengLiang @JohnWick2ETH