Exponentiation circuit and EXP opcode#255
Conversation
bb244fb to
a7144c2
Compare
ChihChengLiang
left a comment
There was a problem hiding this comment.
I reviewed the text description parts.
There are many unorganized questions. Feel free to pick just the ones you feel important to answer
|
@roynalnaruto really nice written spec, very easy to follow the py code from it! I am not able to find anything, just curious about your answers, to approve the PR. |
|
@roynalnaruto any blocker for finishing this PR? |
|
@adria0 no blockers. I am updating the specs repo and also the design document. Should push an update this week |
|
Thanks for the update, @roynalnaruto! |
|
@ChihChengLiang @adria0 Apologies I was a little occupied with some other tasks. I will post updates to the design doc as well as the specs PR this week. Will also post answers to all your comments. Thanks for the review :) |
3d3461e to
7663e2e
Compare
|
@ChihChengLiang I've answered all your questions and updated the documents/specs. Could you review again? |
|
rereviewing now. Thanks for waiting. |
Co-authored-by: Chih Cheng Liang <chihchengliang@gmail.com>
|
@ChihChengLiang updated the PR with all suggestions. Shall we merge it now? |
This PR implements the following:
The
EXPopcode computes the exponentiation result of an integer base to an integer exponent:The exponentiation circuit verifies the exponentiation trace, i.e. intermediate multiplication steps generated by the Exponentiation by Squaring algorithm.
The
EXPopcode gadget does lookups (conditional based on theexponentvalue) to the exponentiation table.