This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix: make exp gadget compatible with circuits impl#300
Merged
roynalnaruto merged 3 commits intoNov 1, 2022
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We define a boolean variable
single_stepwhere:single_step == 1 if exponent == 2single_step == 0 if exponent > 2We don't need any additional constraints on
single_step(not evenrequire_boolean) because it is simply used to do a lookup to the exponentiation circuit. All necessary constraints on that column (exp_circuit.exp_table.is_last) are handled within the exponentiation circuit.This makes the specs gadget compatible with the circuits gadget
@adria0 This is the last pending PR before we can get privacy-ethereum/zkevm-circuits#700 merged