This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix copy log data index in multi steps#206
Merged
Merged
Conversation
ed255
approved these changes
May 24, 2022
ed255
left a comment
ed255
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for updating the specs :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the circuit fix privacy-ethereum/zkevm-circuits#510 has been merged , also change
MAX_COPY_BYTESto 32 aligning with circuit implementation .