Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

(WIP) feat: add sload op#79

Closed
0xmountaintop wants to merge 92 commits into
mainfrom
rework/storage
Closed

(WIP) feat: add sload op#79
0xmountaintop wants to merge 92 commits into
mainfrom
rework/storage

Conversation

@0xmountaintop
Copy link
Copy Markdown

@0xmountaintop 0xmountaintop force-pushed the rework/storage branch 3 times, most recently from 540b63d to 3b8261f Compare January 19, 2022 04:20
@0xmountaintop 0xmountaintop marked this pull request as ready for review January 19, 2022 04:20
@0xmountaintop 0xmountaintop changed the title feat: add sload op (WIP) feat: add sload op Jan 20, 2022
Comment on lines +778 to +783
(
stack_ops.len(),
memory_ops.len(),
storage_ops.len(),
txaccesslist_storage_ops.len(),
),
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Comment on lines +757 to +758
let mut txaccesslist_storage_ops = b.container.sorted_txaccesslist_storage();
txaccesslist_storage_ops.sort_by_key(|s| usize::from(s.rwc()));
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Comment on lines +696 to +698
bus_mapping::operation::Target::TxAccessListAccountStorage => {
index + stack_ops_len + memory_ops_len + storage_ops_len
}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@@ -377,6 +377,11 @@ pub enum Rw {
TxAccessListStorageSlot {
rw_counter: usize,
is_write: bool,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove is_write

@0xmountaintop 0xmountaintop force-pushed the rework/storage branch 3 times, most recently from cfe9361 to 5f07c87 Compare February 11, 2022 16:27
@0xmountaintop 0xmountaintop mentioned this pull request Feb 14, 2022
@0xmountaintop 0xmountaintop deleted the rework/storage branch March 9, 2022 05:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant