Remove overridden capture method in forms code #3468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cee3184 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
force-pushed
the
remove_overridden_capture
branch
from
b2cb2b3 to
292a3e1
Compare
joelhawksley
approved these changes
Apr 30, 2025
francinelucca
approved these changes
Apr 30, 2025
francinelucca
added
the
skip changeset
|
HI CAMERON! |
langermank
approved these changes
Apr 30, 2025
Merged
|
👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR reverts the change made in #1809, which was obviated a long time ago by rails/rails#49612. It's causing test failures on the upcoming ViewComponent v4 branch. This PR fixes the issue and should let us move forward with the next major version of ViewComponent 😄
Screenshots
Integration
I don't think any code changes are necessary in production, but y'all should make sure dotcom doesn't break. I would do it myself, but... well, you know.
Risk Assessment