Skip to content

Remove overridden capture method in forms code #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2025
Merged

Remove overridden capture method in forms code #3468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
292a3e1
Remove overridden capture method in forms code
camertron Apr 30, 2025
53a5630
Add changeset
camertron Apr 30, 2025
b0b42dd
Create hungry-doors-occur.md
joelhawksley Apr 30, 2025
ff3965d
Delete .changeset/fast-coats-smoke.md
joelhawksley Apr 30, 2025
5c2e683
Create funny-moles-walk.md
francinelucca Apr 30, 2025
cee3184
Delete .changeset/funny-moles-walk.md
francinelucca Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-doors-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/view-components": patch
---

Remove overridden capture method in forms code.
13 changes: 1 addition & 12 deletions app/lib/primer/forms/acts_as_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,14 @@ module Forms
module ActsAsComponent
# :nodoc:
module InstanceMethods
delegate :render, :content_tag, :output_buffer, to: :@view_context
delegate :render, :content_tag, :output_buffer, :capture, to: :@view_context

def render_in(view_context, &block)
@view_context = view_context
before_render
perform_render(&block)
end

# This is necessary to restore the functionality changed by https://github.com/rails/rails/pull/47194.
# I would love to remove this at some point, perhaps if we ever decide to replace
# ActsAsComponent with view component.
def capture(*args, &block)
old_buffer = @view_context.output_buffer
@view_context.output_buffer = ActionView::OutputBuffer.new
@view_context.capture(*args, &block)
ensure
@view_context.output_buffer = old_buffer
end

# :nocov:
def perform_render(&_block)
raise NotImplementedError, "subclasses must implement ##{__method__}."
Expand Down
Loading