Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update lit labs imports" #5323

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hussam-i-am
Copy link
Collaborator

@hussam-i-am hussam-i-am commented Nov 21, 2024

Reverts #5321 due to error in integration tests:

 Error: #Renders repo-attestations show
  Occurred at: ui/packages/list-view/src/ListItem/DescriptionItem.tsx:11
  
  Error:Error: Expected test not to call console.error().
  
  If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.
  
  Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://reactjs.org/link/uselayouteffect-ssr for common fixes.
      at useRef (/workspace/github/node_modules/@primer/react/lib/node_modules/@lit/react/create-component.js:8:561)
      at shouldForwardProp (/workspace/github/node_modules/styled-components/src/models/StyledComponent.js:247:26)
      at date (/workspace/github/node_modules/@primer/react/lib/RelativeTime/RelativeTime.js:20:3)
      at div
      at shouldForwardProp (/workspace/github/node_modules/styled-components/src/models/StyledComponent.js:247:26)
  [...truncated...]

@hussam-i-am hussam-i-am self-assigned this Nov 21, 2024
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 21, 2024 22:33
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 7f2e9b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hussam-i-am hussam-i-am requested review from mattcosta7 and removed request for jonrohan November 21, 2024 22:33
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 101.35 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 101.52 KB (-0.1% 🔽)

@joshblack
Copy link
Member

Sharing the last time we looked at this for reference: #3708

I believe this will be addressed when PRC goes ESM only but things might have changed since then, not sure 👀

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 75acf7a Nov 21, 2024
48 checks passed
@hussam-i-am hussam-i-am deleted the revert-5321-update-lit-labs-imports branch November 21, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants