Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lit labs imports #5321

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Update lit labs imports #5321

merged 6 commits into from
Nov 21, 2024

Conversation

mattcosta7
Copy link
Collaborator

@mattcosta7 mattcosta7 commented Nov 20, 2024

Updates @lit-labs/react to @lit/react

Changelog

Just updates a dependency

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 5a20302

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 20, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5321 November 20, 2024 21:21 Inactive
Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.52 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 100.92 KB (-0.09% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5321 November 20, 2024 21:27 Inactive
@mattcosta7 mattcosta7 marked this pull request as ready for review November 20, 2024 21:34
@mattcosta7 mattcosta7 requested a review from a team as a code owner November 20, 2024 21:34
@mattcosta7 mattcosta7 self-assigned this Nov 20, 2024
@mattcosta7 mattcosta7 added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@mattcosta7 mattcosta7 added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@mattcosta7 mattcosta7 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 424d4a7 Nov 21, 2024
43 checks passed
@mattcosta7 mattcosta7 deleted the update-lit-labs-imports branch November 21, 2024 13:29
@primer primer bot mentioned this pull request Nov 21, 2024
@hussam-i-am
Copy link
Collaborator

Looks like this is causing integration failures with dotcom

 Error: #Renders repo-attestations show
  Occurred at: ui/packages/list-view/src/ListItem/DescriptionItem.tsx:11
  
  Error:Error: Expected test not to call console.error().
  
  If the error is expected, test for it explicitly by mocking it out using jest.spyOn(console, 'error').mockImplementation() and test that the warning occurs.
  
  Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://reactjs.org/link/uselayouteffect-ssr for common fixes.
      at useRef (/workspace/github/node_modules/@primer/react/lib/node_modules/@lit/react/create-component.js:8:561)
      at shouldForwardProp (/workspace/github/node_modules/styled-components/src/models/StyledComponent.js:247:26)
      at date (/workspace/github/node_modules/@primer/react/lib/RelativeTime/RelativeTime.js:20:3)
      at div
      at shouldForwardProp (/workspace/github/node_modules/styled-components/src/models/StyledComponent.js:247:26)
  [...truncated...]

hussam-i-am added a commit that referenced this pull request Nov 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants