fix(useDetails): update ref type #2656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8a297ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Member
Author
|
@siddharthkp hope the changes make sense, let me know if I'm missing anything! |
colebemis
approved these changes
Dec 15, 2022
joshblack
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2620
Closes #2146
Changelog
New
Changed
reffromuseDetailstoHTMLDetailsElementRemoved
Testing & Reviewing
I couldn't figure out a good test strategy locally for this, let me know if you have any tips! I ended up having to create a distinct folder and use the published package (or link locally). Something like:
npx create-react-app details-example --template typescript cd details-example npm i @primer/react styled-components npm run buildInitially, this will fail with the error from the parent issues. When updating
@primer/reactinpackage.json, this error will no longer show up when building.