Skip to content

fix(useDetails): update ref type #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 3 commits into from
Dec 16, 2022
Merged

fix(useDetails): update ref type #2656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8054b54
fix(useDetails): update ref type
joshblack Dec 6, 2022
46ad370
chore: add changeset
joshblack Dec 6, 2022
8a297ae
Merge branch 'main' into 2620-update-ref-type-details
joshblack Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-feet-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Update useDetails `ref` type to HTMLDetailsElement
4 changes: 2 additions & 2 deletions src/hooks/useDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {useCallback, useEffect, useState, useRef} from 'react'

type UseDetailsParameters = {
ref?: React.RefObject<HTMLElement>
ref?: React.RefObject<HTMLDetailsElement>
closeOnOutsideClick?: boolean
defaultOpen?: boolean
onClickOutside?: (event: MouseEvent) => void
Expand All @@ -16,7 +16,7 @@ function useDetails({ref, closeOnOutsideClick, defaultOpen, onClickOutside}: Use
(event: MouseEvent) => {
const {current} = customRef
const eventTarget = event.target as HTMLElement
const closest = eventTarget.closest('details') as HTMLDetailsElement
const closest = eventTarget.closest('details')
if (closest !== current) {
onClickOutside && onClickOutside(event)
if (!event.defaultPrevented) {
Expand Down