Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean-up dependabot, ci, codeowners #88

Merged
merged 2 commits into from
Oct 12, 2023
Merged

chore: clean-up dependabot, ci, codeowners #88

merged 2 commits into from
Oct 12, 2023

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Oct 11, 2023 •
edited
Loading

Changelog

New

  • Add .nvmrc file for Node.js support

Changed

  • Update dependabot to scan for all dependencies, include github-actions as well
  • Update CI to only run on Node.js LTS (v18)
  • Move CODEOWNERS to .github/CODEOWNERS

Removed

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5616ba4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack mentioned this pull request Oct 11, 2023
Closed
broccolinisoup
broccolinisoup reviewed Oct 12, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for pushing these PRs! Left comments about the version of some actions - let me know what you think!

.github/dependabot.yml
@@ -1,10 +1,16 @@
version: 2
updates:
- package-ecosystem: 'github-actions'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just love these 🔥

.github/dependabot.yml
schedule:
interval: weekly
open-pull-requests-limit: 99
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-pull-requests-limit: 99

Oo never seen this before 😄

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@broccolinisoup broccolinisoup mentioned this pull request Oct 12, 2023
Merged
@joshblack joshblack merged commit fc0af87 into main Oct 12, 2023
3 checks passed
@joshblack joshblack deleted the chore/repo-dependabot-codeowners-cleanup branch October 12, 2023 20:11
@joshblack joshblack mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @broccolinisoup