Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eslint): add eslint support #89

Merged
merged 10 commits into from
Oct 12, 2023
Merged

chore(eslint): add eslint support #89

merged 10 commits into from
Oct 12, 2023

Conversation

joshblack
Copy link
Member

Changelog

New

  • Add support for eslint through .eslintrc.js
  • Add lint job to CI

Changed

  • Update code to fix eslint errors

Removed

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: af69005

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

broccolinisoup
broccolinisoup approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the markdown linter but approving in advance - looks great 🚀

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@joshblack joshblack requested a review from a team October 12, 2023 20:21
@joshblack joshblack merged commit 5257a79 into main Oct 12, 2023
6 checks passed
@joshblack joshblack deleted the chore/add-eslint-support branch October 12, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @broccolinisoup