Skip to content

Conversation

@electrum
Copy link
Contributor

No description provided.

@dain
Copy link
Contributor

dain commented Aug 21, 2012

I'm not sure why this is needed at all given you can create an UncompressedValueBlock if you have a slice.

@electrum electrum closed this Aug 21, 2012
losipiuk pushed a commit to losipiuk/prestodb that referenced this pull request Nov 17, 2015
Update the list of system schemas.
losipiuk pushed a commit to losipiuk/prestodb that referenced this pull request Dec 1, 2015
Update the list of system schemas.
billonahill pushed a commit to billonahill/presto that referenced this pull request Dec 8, 2015
miniway pushed a commit to miniway/presto_legacy that referenced this pull request Feb 16, 2016
ehalpern pushed a commit to ehalpern/presto that referenced this pull request Oct 23, 2017
This doubles the bytes per batch. This required configuring the
thrift frame size on both client and server and also configuring
presto-thrift.max-response-size. Unfortunately, the later is
limited at 32MB.

Also increase the confidence in row size estimation to further
maximize bytes per request.

fixes: prestodb#3
piyushnarang pushed a commit to piyushnarang/presto that referenced this pull request Aug 10, 2018
Migrate Presto to use Hive on Mesos.
cryptoe added a commit to cryptoe/presto that referenced this pull request Oct 4, 2018
# This is the 1st commit message:

# This is a combination of 8 commits.
# This is the 1st commit message:

# This is a combination of 6 commits.
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:

# This is a combination of 6 commits.
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 4 commits.
# This is the 1st commit message:

# This is a combination of 2 commits.
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:

# This is a combination of 4 commits.
# This is the 1st commit message:

 WIP: Ranger integration with presto. Please change local file path

# This is the commit message prestodb#2:

Making information schema skippable

# This is the commit message prestodb#3:

minor improvements

# This is the commit message prestodb#4:

Fix truncated print for ProjectionNode in PlanPrinter

# This is the commit message prestodb#2:

Cleanup all temporary files when writing sorted Hive tables

# This is the commit message prestodb#3:

Prevent nulls fraction to be negative in subtractColumnStats

# This is the commit message prestodb#2:

Better estimate NDVs and range in subtractColumnStats

When there is too little rows per distinct values to
be substracted, then both original range and NDVs
should be preserved.

# This is the commit message prestodb#2:

Mark subtractColumnStats as @deprecated as it semantics is undefined

# This is the commit message prestodb#3:

Dispose resources in WorkProcessorUtils when they are no longer needed

# This is the commit message prestodb#4:

Add WorkProcessor#transformProcessor method

This methods allows to write more streamlined
transformations of the processor itself, e.g:

processor.transformProcessor(WorkProcessorUtils::flatten)

# This is the commit message prestodb#2:

Fix error message in QuerySessionSupplier

# This is the commit message prestodb#2:

Rename singleExpression to standaloneExpression

This better reflects the intent of the parsing rule.

# This is the commit message prestodb#2:

Improve parsing error message

The name appears as the prefix of some errors. E.g.,

    xxxxx is too large (stack overflow while parsing)

"path specification" reads better than "pathSpec"

# This is the commit message prestodb#3:

Log raised during error handling

It was logging the parsing exception, not the exception that could
occur while handling the parsing error due to a bug in the implementation.

# This is the commit message prestodb#2:

Tighten assertion for parsing failure in TestSqlEnvironmentConfig

# This is the commit message prestodb#3:

Implement recursion-free ATN simulator

The new implementation tracks all the possible states the ATN can be
in in a single queue instead of recursing when processing sub-rules.

This vastly simplifies the code, makes it easier to reason about and
debug. It also fixes a latent bug where some contexts were not being
visited, which missed some candidate tokens.

# This is the commit message prestodb#4:

Raise requried Java version to 8u151

Some test cases failed due to JDK MethodHandle bug in 8u92.
These tests passed in 8u151.

# This is the commit message prestodb#5:

Track origin column for fields

This is needed to ensure we only check column access privileges for
origin columns.

# This is the commit message prestodb#6:

Don't check column access for aliases

Fixes queries that have column aliases defined in the query like
`SELECT col1 AS my_alias FROM table`.  Previously, we checked if a
user had permission to access "col1" and "my_alias". Now we only
 check "col1".

# This is the commit message prestodb#2:

Add wrapped Boolean benchmarks

Benchmark                                         Mode  Cnt     Score    Error   Units
BenchmarkBoxedBoolean.booleanEquals              thrpt   30  4596.863 ± 26.817  ops/ms
BenchmarkBoxedBoolean.booleanEqualsNotNull       thrpt   30  4484.421 ± 43.358  ops/ms
BenchmarkBoxedBoolean.identity                   thrpt   30  4610.811 ± 85.104  ops/ms
BenchmarkBoxedBoolean.object                     thrpt   30  4558.072 ± 68.325  ops/ms
BenchmarkBoxedBoolean.primitive                  thrpt   30  4450.140 ± 52.258  ops/ms
BenchmarkBoxedBoolean.unboxing                   thrpt   30  4506.205 ± 26.116  ops/ms

# This is the commit message prestodb#3:

Implement equality comparisons projection benchmark

Bechmark creates an expression with 100 comparisions concatenated with
OR and executes them on a single 1MB page with 10 BIGINT channels.

Before change:

Benchmark                                  Mode  Cnt     Score    Error  Units
BenchmarkEqualsOperator.processPage	   avgt   15  5164.793 ± 29.110  us/op

After change:

Benchmark                                  Mode  Cnt     Score    Error  Units
BenchmarkEqualsOperator.processPage	   avgt   15  5142.010 ± 59.681  us/op

# This is the commit message prestodb#2:

Implement nullable EQUAL and NOT_EQUAL for ARRAY type

# This is the commit message prestodb#3:

Change equals semantincs for null in MAP

Make it comptible with current ARRAY equals semantics

If the key sets are different - return false.
If the key sets are the same - compare the values as if they
were arrays sorted by the keys.

# This is the commit message prestodb#4:

Implement nullable EQUAL and NOT_EQUAL for ROW type

# This is the commit message prestodb#5:

Support IN predicate for complex type values with nulls

# This is the commit message prestodb#6:

Allow alternate implementations of HiveMetadata

Extracting an interface allows implementations that use delegation
rather than subclasses.

# This is the commit message prestodb#2:

Fix handling of thread interruption in JDBC driver

When using sockets created using SocketChannel, OkHttp handles thread
interruption differently and does not restore the interrupt status.

# This is the commit message prestodb#3:

Add per table column_ranges system table in Raptor

# This is the commit message prestodb#4:

Fix Hive smoke test when running in parallel

Use a different table name for testCreateEmptyBucketedPartition
and testInsertPartitionedBucketedTable to avoid test failures
when running in parallel.

# This is the commit message prestodb#5:

Separate EXCEEDED_MEMORY_LIMIT error into local and global

# This is the commit message prestodb#6:

Fix test failures due to ExceededMemoryLimitException message

# This is the commit message prestodb#7:

Fix more test failures due to ExceededMemoryLimitException message

A few tests failures are not fixed by
47355c8

# This is the commit message prestodb#8:

Replace usage of deprecated TreeTraverser

# This is the commit message prestodb#2:

Add missing column to verifier SQL documentation
VicoWu pushed a commit to VicoWu/facebook-presto-legacy that referenced this pull request Nov 3, 2018
…thored by Shashank- Snowflake connector.

* Changing timeout to 5 minutes and HashSet import order.

* Build fails on import order, just changing the value instead of the TimeUnit.

* Presto snowflake connector. (prestodb#3)

* Use hulu snowflake version

* Add hulu reposities
imakhlin pushed a commit to imakhlin/presto that referenced this pull request Oct 15, 2019
* Add more details on decrypt failure

* Fix log line format

* Fix code style according to presto standards

* handle exceptions
ajaygeorge referenced this pull request in ajaygeorge/presto Sep 23, 2020
sabbasani referenced this pull request in sabbasani/presto Jun 19, 2024
# This is the 1st commit message:

Arrow-flight connector

# This is the commit message #2:

cleanup code

# This is the commit message #3:

cleanup code

# This is the commit message #4:

cleanup code

# This is the commit message #5:

removing use of token
Mariamalmesfer pushed a commit to Mariamalmesfer/presto that referenced this pull request Oct 10, 2024
# This is the 1st commit message:

okhttp to 4.12.0

# This is the commit message prestodb#2:

upgrade okie to 4.12.0

# This is the commit message prestodb#3:

upgrade okie to 4.12.0

# This is the commit message prestodb#4:

upgrade okie to 4.12.0

# This is the commit message prestodb#5:

upgrade okie to 4.12.0

# This is the commit message prestodb#6:

upgrade okie to 4.12.0
Leziak pushed a commit to Leziak/presto that referenced this pull request Apr 9, 2025
# This is the 1st commit message:

[native] Add a test group for async data cache e2e tests.

# This is the commit message prestodb#2:

[native] Advance velox.

# This is the commit message prestodb#3:

Fix error when describing a nonexistent table

# This is the commit message prestodb#4:

[native] test modification.

# This is the commit message prestodb#5:

Changes to enable ssl/tls in hms
Co-authored-by: Arin Mathew <arin.mathew1@ibm.com>

Changes to move ssl related properties to seperate class

# This is the commit message prestodb#6:

[native] Add tests for UUID type

# This is the commit message prestodb#7:

Reintroduced json_extract to generate canonicalized output (prestodb#24879)

## Description
The original pull request
[prestodb#24614](prestodb#24614) incorrectly
compares canonicalizedJsonExtract and legacyJsonCast in the equals
function of an object. This issue can be seen in the code
[here](https://github.com/prestodb/presto/pull/24614/files#diff-e921c5d186f9d5daa836bc7330f52caf8c1b84d19cf42288d5a8a7c9a6d2a5d5R156).

As a result, whenever a SQL function requires caching, the cache is
never hit, leading to the creation of new SQL function objects
repeatedly. This behavior eventually causes an OOM error in the JVM
metaspace. and eventually this error led to UER SEV.

After the problematic comparison was updated and tested through shadow
cluster by @rschlussel , we are confident that the issue has been
resolved in this PR. Therefore, we plan to bring back the json
canonicalized extract


## Motivation and Context
Reintroduced json_extract to generate canonicalized output

## Impact
<!---Describe any public API or user-facing feature change or any
performance impact-->
low impact 

## Test Plan
<!---Please fill in how you tested your change-->
N/A

## Contributor checklist

- [x] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [x] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [x] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [x] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [x] Adequate tests were added if applicable.
- [x] CI passed.

## Release Notes
Please follow [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines)
and fill in the release notes below.

```
== NO RELEASE NOTE ==
```
# This is the commit message prestodb#8:

Reuse JoinType in IndexJoinNode

Reuse JoinType instead of creating IndexJoinNode's own. JoinType is
already part of Prestissimo protocol. Adding IndexJoinNode with another
JoinType would cause naming conflict.

# This is the commit message prestodb#9:

Add jaro-winkler implementation, documentation and tests

# This is the commit message prestodb#10:

Add documentation for Iceberg support in PrestoCPP

# This is the commit message prestodb#11:

Add memory pool debug regex

# This is the commit message prestodb#12:

doc on hive csv limitations

# This is the commit message prestodb#13:

Add support for S3 WebIdentity authentication

# This is the commit message prestodb#14:

use com.facebook.airlift:security in presto-hive-metastore

# This is the commit message prestodb#15:

[native] Advance Velox

# This is the commit message prestodb#16:

[native] Add protocol for index lookup join plan

# This is the commit message prestodb#17:

[native] Add sidecar and sidecar plugin documentation
zation99 added a commit to zation99/presto that referenced this pull request Nov 4, 2025
Summary:
1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit to zation99/presto that referenced this pull request Nov 4, 2025
Summary:

1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit to zation99/presto that referenced this pull request Nov 4, 2025
Summary:

1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit to zation99/presto that referenced this pull request Nov 4, 2025
Summary:

1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit to zation99/presto that referenced this pull request Nov 4, 2025
Summary:

1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit to zation99/presto that referenced this pull request Nov 5, 2025
Summary:

1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during session creation

For prestodb#3, we need a follow up to understand why the check of setting transaction id and catalog properties during session constructor is needed. I don't see a clear reason by checking the previous relavant commits. I'll check with some additional people. If no clear objection, I'll remove that check at least from the Session constructor in following PRs, and restoring the copy of catalog properties in buildOwnerSession().

Differential Revision: D86223888
zation99 added a commit that referenced this pull request Nov 5, 2025
Summary:
1. Fix an error of refresh MV after base table insertion
2. Use ExpressionUtil in MV refresh query composing
3. Fix an issue in MV caused by copying catalog properties during
session creation

For #3, we need a follow up to understand why the check of setting
transaction id and catalog properties during session constructor is
needed. I don't see a clear reason by checking the previous relavant
commits. I'll check with some additional people. If no clear objection,
I'll remove that check at least from the Session constructor in
following PRs, and restoring the copy of catalog properties in
buildOwnerSession().

Differential Revision: D86223888

## Release Notes

```
== NO RELEASE NOTE ==
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants