Fix requiredField logic in StructSelectiveStreamReader#13884
Merged
mbasmanova merged 1 commit intoprestodb:masterfrom Dec 21, 2019
Merged
Fix requiredField logic in StructSelectiveStreamReader#13884mbasmanova merged 1 commit intoprestodb:masterfrom
mbasmanova merged 1 commit intoprestodb:masterfrom
Conversation
mbasmanova
reviewed
Dec 20, 2019
Contributor
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
@bhhari Thanks for fixing this.
presto-hive/src/test/java/com/facebook/presto/hive/TestHivePushdownFilterQueries.java
Outdated
Show resolved
Hide resolved
presto-orc/src/main/java/com/facebook/presto/orc/reader/StructSelectiveStreamReader.java
Outdated
Show resolved
Hide resolved
bhhari
force-pushed
the
fix_struct_reader
branch
2 times, most recently
from
2cec773 to
5e03c0e
Compare
mbasmanova
approved these changes
Dec 20, 2019
Read only the required sub-fields when the entire struct column is not projected and there is a top level not null on it. Current code is trying to read all nested fields and results in an error "filter must be present if outputRequired is false"
bhhari
force-pushed
the
fix_struct_reader
branch
from
5e03c0e to
46a47ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following exception