Skip to content

Update base-arrow-flight.rst #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sabbasani merged 3 commits into from
Jul 25, 2024
Merged

Update base-arrow-flight.rst #2

sabbasani merged 3 commits into from
Jul 25, 2024

Conversation

@SthuthiGhosh9400
Copy link
Collaborator

@SthuthiGhosh9400 SthuthiGhosh9400 commented Jul 25, 2024

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

elbinpallimalilibm
elbinpallimalilibm reviewed Jul 25, 2024
View reviewed changes
presto-docs/src/main/sphinx/connector/base-arrow-flight.rst Outdated
Register your connector name by extending the ArrowPlugin class.

* ``ArrowFlightRequest``
The ``getCommand`` method in the ``ArrowFlightRequest`` interface is responsible for serializing a flight request object into a JSON byte array.
Copy link
Collaborator

@elbinpallimalilibm elbinpallimalilibm Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The byte array may not be from JSON string, so no need to mention JSON

elbinpallimalilibm
elbinpallimalilibm reviewed Jul 25, 2024
View reviewed changes
presto-docs/src/main/sphinx/connector/base-arrow-flight.rst Outdated
Register your connector name by extending the ArrowPlugin class.

* ``ArrowFlightRequest``
The ``getCommand`` method in the ``ArrowFlightRequest`` interface is responsible for serializing a flight request object into a byte array.
Copy link
Collaborator

@elbinpallimalilibm elbinpallimalilibm Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can reword like "The getCommand method in ........ should return a byte array for the flight request.

@sabbasani sabbasani merged commit 1c18d1b into sabbasani:arrow-connector Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elbinpallimalilibm elbinpallimalilibm elbinpallimalilibm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SthuthiGhosh9400 @elbinpallimalilibm @sabbasani