Skip to content

build(deps): Install_ucx in centos-dependency image#27118

Merged
majetideepak merged 4 commits intoprestodb:masterfrom
karthikeyann:patch-1
Feb 13, 2026
Merged

build(deps): Install_ucx in centos-dependency image#27118
majetideepak merged 4 commits intoprestodb:masterfrom
karthikeyann:patch-1

Conversation

@karthikeyann
Copy link
Copy Markdown
Contributor

@karthikeyann karthikeyann commented Feb 10, 2026

Description

Install ucx on dependency image so that we can use same dependency image while working with presto/master and presto/ibm-research-review branches.

Motivation and Context

While working with new cudf-exchange feature, rebuilding centos dependency image overwrites old image, and this causes frequent rebuild while working with presto/master and presto/ibm-research-review branches. Installing UCX on the dependency image will not affect presto/master, but it is required for presto/ibm-research-review branch

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.
  • If adding new dependencies, verified they have an OpenSSF Scorecard score of 5.0 or higher (or obtained explicit TSC approval for lower scores).

Release Notes

== NO RELEASE NOTE ==

Summary by Sourcery

Build:

  • Add UCX installation step to the CentOS dependency Dockerfile used for native execution builds.

@karthikeyann karthikeyann requested review from a team as code owners February 10, 2026 01:33
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CentOS dependency Docker image build script to install UCX alongside existing CUDA and adapter tooling so the same image can be used for both presto/master and presto/ibm-research-review branches.

Flow diagram for updated CentOS dependency Docker build step

flowchart TD
    A[Start dependency image build] --> B[Create build directory]
    B --> C[Run setup-centos-adapters.sh]
    C --> D[install_adapters]
    D --> E[install_clang15]
    E --> F[install_cuda 12.8]
    F --> G[install_ucx]
    G --> H[Remove build directory]
    H --> I[End dependency image build]
Loading

File-Level Changes

Change Details Files
Extend the CentOS dependency Docker build to install UCX in addition to CUDA and other Velox-related tooling.
  • Modify the composite bash command in the Dockerfile RUN step to invoke install_ucx after installing CUDA
  • Keep the rest of the Velox/Clang/CUDA setup pipeline unchanged and continue cleaning up the temporary build directory
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@karthikeyann karthikeyann changed the title install_ucx in centos-dependency image build(deps): install_ucx in centos-dependency image Feb 10, 2026
@karthikeyann karthikeyann changed the title build(deps): install_ucx in centos-dependency image build(deps): Install_ucx in centos-dependency image Feb 10, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In the Dockerfile RUN block, install_ucx is currently on a new line without being chained (e.g., && install_ucx \); as written it will likely break the shell command grouping—please ensure it’s properly joined to install_cuda within the same bash -c command and line-continuation sequence.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In the Dockerfile RUN block, `install_ucx` is currently on a new line without being chained (e.g., `&& install_ucx \`); as written it will likely break the shell command grouping—please ensure it’s properly joined to `install_cuda` within the same `bash -c` command and line-continuation sequence.

## Individual Comments

### Comment 1
<location> `presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile:38-39` </location>
<code_context>
                  install_adapters && \
                  install_clang15 && \
-                 install_cuda 12.8) && \
+                 install_cuda 12.8
+                 install_ucx) && \
     rm -rf build"

</code_context>

<issue_to_address>
**issue (bug_risk):** Missing `&&` between `install_cuda` and `install_ucx` removes fail-fast behavior in the subshell.

Because `install_cuda 12.8` is no longer the last command in the subshell and isn’t chained with `install_ucx`, a CUDA failure won’t cause the subshell to exit, and the final status will only reflect `install_ucx`. To keep fail-fast behavior, chain them:

```dockerfile
                 install_cuda 12.8 && \
                 install_ucx) && \
```

This ensures the overall step fails if CUDA installation does.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@karthikeyann
Copy link
Copy Markdown
Contributor Author

@majetideepak please re-trigger failed tests (due to no space left on device)

Pull changes from PR prestodb#27074
Add UCX version used in ibm-research-preview branch
Copy link
Copy Markdown
Contributor

@pramodsatya pramodsatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karthikeyann.

@majetideepak
Copy link
Copy Markdown
Collaborator

@zoltan any concerns?

@majetideepak majetideepak merged commit 2a5a908 into prestodb:master Feb 13, 2026
112 of 113 checks passed
czentgr pushed a commit that referenced this pull request Feb 14, 2026
## Description

PR #27118 broke this Dockerfile by leaving an extra closing parenthesis
after `${CUDA_VERSION}`.

## Motivation and Context

Fixes build.

## Impact

Fixes build.

## Test Plan

None.

## Contributor checklist

- [ ] Please make sure your submission complies with our [contributing
guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md),
in particular [code
style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style)
and [commit
standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards).
- [ ] PR description addresses the issue accurately and concisely. If
the change is non-trivial, a GitHub Issue is referenced.
- [ ] Documented new properties (with its default value), SQL syntax,
functions, or other functionality.
- [ ] If release notes are required, they follow the [release notes
guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines).
- [ ] Adequate tests were added if applicable.
- [ ] CI passed.
- [ ] If adding new dependencies, verified they have an [OpenSSF
Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or
higher (or obtained explicit TSC approval for lower scores).

== NO RELEASE NOTE ==

## Summary by Sourcery

Bug Fixes:
- Correct a syntax error in the CentOS dependency Dockerfile that
prevented the build from running successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants