build(deps): Install_ucx in centos-dependency image#27118
Merged
majetideepak merged 4 commits intoprestodb:masterfrom Feb 13, 2026
Merged
build(deps): Install_ucx in centos-dependency image#27118majetideepak merged 4 commits intoprestodb:masterfrom
majetideepak merged 4 commits intoprestodb:masterfrom
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CentOS dependency Docker image build script to install UCX alongside existing CUDA and adapter tooling so the same image can be used for both presto/master and presto/ibm-research-review branches. Flow diagram for updated CentOS dependency Docker build stepflowchart TD
A[Start dependency image build] --> B[Create build directory]
B --> C[Run setup-centos-adapters.sh]
C --> D[install_adapters]
D --> E[install_clang15]
E --> F[install_cuda 12.8]
F --> G[install_ucx]
G --> H[Remove build directory]
H --> I[End dependency image build]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In the Dockerfile RUN block,
install_ucxis currently on a new line without being chained (e.g.,&& install_ucx \); as written it will likely break the shell command grouping—please ensure it’s properly joined toinstall_cudawithin the samebash -ccommand and line-continuation sequence.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the Dockerfile RUN block, `install_ucx` is currently on a new line without being chained (e.g., `&& install_ucx \`); as written it will likely break the shell command grouping—please ensure it’s properly joined to `install_cuda` within the same `bash -c` command and line-continuation sequence.
## Individual Comments
### Comment 1
<location> `presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile:38-39` </location>
<code_context>
install_adapters && \
install_clang15 && \
- install_cuda 12.8) && \
+ install_cuda 12.8
+ install_ucx) && \
rm -rf build"
</code_context>
<issue_to_address>
**issue (bug_risk):** Missing `&&` between `install_cuda` and `install_ucx` removes fail-fast behavior in the subshell.
Because `install_cuda 12.8` is no longer the last command in the subshell and isn’t chained with `install_ucx`, a CUDA failure won’t cause the subshell to exit, and the final status will only reflect `install_ucx`. To keep fail-fast behavior, chain them:
```dockerfile
install_cuda 12.8 && \
install_ucx) && \
```
This ensures the overall step fails if CUDA installation does.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
presto-native-execution/scripts/dockerfiles/centos-dependency.dockerfile
Outdated
Show resolved
Hide resolved
7 tasks
Contributor
Author
|
@majetideepak please re-trigger failed tests (due to no space left on device) |
Pull changes from PR prestodb#27074 Add UCX version used in ibm-research-preview branch
pramodsatya
approved these changes
Feb 10, 2026
Contributor
pramodsatya
left a comment
There was a problem hiding this comment.
Thanks @karthikeyann.
majetideepak
approved these changes
Feb 13, 2026
Collaborator
|
@zoltan any concerns? |
7 tasks
czentgr
pushed a commit
that referenced
this pull request
Feb 14, 2026
## Description PR #27118 broke this Dockerfile by leaving an extra closing parenthesis after `${CUDA_VERSION}`. ## Motivation and Context Fixes build. ## Impact Fixes build. ## Test Plan None. ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). == NO RELEASE NOTE == ## Summary by Sourcery Bug Fixes: - Correct a syntax error in the CentOS dependency Dockerfile that prevented the build from running successfully.
This was referenced Mar 31, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Install ucx on dependency image so that we can use same dependency image while working with presto/master and presto/ibm-research-review branches.
Motivation and Context
While working with new cudf-exchange feature, rebuilding centos dependency image overwrites old image, and this causes frequent rebuild while working with presto/master and presto/ibm-research-review branches. Installing UCX on the dependency image will not affect presto/master, but it is required for presto/ibm-research-review branch
Contributor checklist
Release Notes
Summary by Sourcery
Build: